-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grand unified preferences dialog #7384
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
29920df
Introduced SimplePreferencesDialog and converted CustomizeGeneralFiel…
calixtus 7e83e3f
Moved preferences tabs to their own packages
calixtus 00a13b8
Removed SetupGeneralFieldsAction
calixtus 0477242
Converted ImportCustomizationDialog
calixtus a038042
Converted ExportCustomizationDialog
calixtus 57c49e1
Cleanups and l10m
calixtus a4f29dd
Checkstyle
calixtus 1fda9c3
Cleanups
calixtus ffeb239
Converted ManageJournalAbbreviations
calixtus 30b435d
l10n
calixtus d42670d
Converted KeyBindingsDialog
calixtus 0af42f4
l10n
calixtus 280aed7
Fixed checkstyle and tests
calixtus 97a1146
Converted ManageProtectedTermsDialog
calixtus ee19398
Simplified call to CitationKeyPatternPanel in markup
calixtus fd0f821
Removed hardwired width settings
calixtus 784eb5d
Renamed files for consistent naming scheme
calixtus 0d4205d
Fixed dependency injection and renamed variables for consistency
calixtus 2e186f5
CHANGELOG.md
calixtus d1ca90b
Final cleanups
calixtus 0c7cd39
Merge remote-tracking branch 'upstream/master' into grupd
calixtus bdb1560
Fixed simple remarks
calixtus cc29b5f
Fixed localization tests
calixtus 3823490
Merge remote-tracking branch 'upstream/master' into grupd
calixtus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a so called PseudoAbbreviation. I have not really understood what the real benefit is of this (maybe one can doubleclick an empty space in the List and insert a new abbreviation?) It's buggy, makes the code quite complicated to understand and I see no real benefit in it. ... ... But I put it back in for now, as several tests break, because they expect this PseudoAbbreviation and it would take me now valuable life time I would rather like to spend in finishing this PR, maybe as soon as I have completed everything else...