Dd2480 2021 group 22 fix for issue 7452 #7534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds ignore parameter to mime type and notify the user if the file downloaded is HTML.
Use Localization when writing messages in the status bar.
replace StringUtils::substringBefore with String::substring
Add test ensuring the UI warns the user if they download a linked HTML file (i.e. a web page).
The test checks the resulting file type when downloading a HTML file.
Add check to only process the mimeType if an ';' exists inside the string
Tests that mime type with parameter value is parsed correctly to exclude the parameter.
Sets a new system-wide cookie manager if there is none, and sets the cookie policy to ACCEPT_NONE after each test.
Clean up code styling according to JabRef style guidelines.
…roup-22/jabref into fix-for-issue-7452
…roup-22/jabref into DD2480-2021-group-22-fix-for-issue-7452 * 'fix-for-issue-7452' of https://github.com/DD2480-2021-group-22/jabref: Refactor LinkedFileViewModelTest removing redundant code (#7452) Refactor LinkedFileViewModelTest removing redundant code (#7452) Refactor LinkedFileViewModelTest adding mock for JabRefPreferences used in testing (#7452) Remove duplicate changelog entry (#7452) Clean up code style (#7452) Clean up code styling according to JabRef style guidelines. Add test for when a linked file points to a PDF url (#7452) Reset cookie policy in test (#7452) Clarify changes (#7452) Add changes to changelog (#7452) Add unit test for mime type parsing (#7452) Fix mime type parsing bug (#7452) Add check to only process the mimeType if an ';' exists inside the string Add unit test for HTML file (#7452) Add UI test (#7452) Add test ensuring the UI warns the user if they download a linked HTML file (i.e. a web page). Replace apache StringUtils (#7452) replace StringUtils::substringBefore with String::substring Add debug message (#7452) Update status bar message (#7452) Ignore mime type params (#7452)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)