Custom DOI base address fix #7569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Mar 26, 2021
| } catch (IOException e) { | ||
| dialogService.showErrorDialogAndWait(Localization.lang("Unable to open link."), e); | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| private void openCustomDOI(String link) { |
There was a problem hiding this comment.
I saw that this method is a duplicate of the one in the Entry Editor. To avoid code duplication, I think it could be useful to extract this method to a static method in JabRefDesktop and then call that. You would need to pass the prefs as parameter then
Siedlerchr
requested changes
Mar 26, 2021
Siedlerchr
added
the
status: changes required
Siedlerchr
approved these changes
Mar 29, 2021
Siedlerchr
added
status: ready-for-review
Siedlerchr
added a commit
that referenced
this pull request
Apr 11, 2021
* upstream/main: Main instead of master Custom DOI base address fix (#7569) Change export to save (#7518) Bump unoloader from 7.1.1 to 7.1.2 (#7609) Bump org.beryx.jlink from 2.23.5 to 2.23.6 (#7610) Bump com.adarshr.test-logger from 2.1.1 to 3.0.0 (#7611) Bump libreoffice from 7.1.1 to 7.1.2 (#7612) Squashed 'buildres/csl/csl-styles/' changes from e1acabe..bfa3b6d (#7603) Rename master to main
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in
Fixes #7337 the option to choose custom DOI base address did not propagate to
LibraryTaband this PR aims to solve exactly that. In the process I refactoredLinkedIdentifierColumnso that it usesOpenUrlActionas well.CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)