Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for org.jabref.gui classes #7578

Closed
wants to merge 18 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
package org.jabref.gui.autocompleter;

import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;

import static org.junit.jupiter.api.Assertions.assertEquals;

public class AppendPersonNamesStrategyTest {

@Test
void testWithoutParam() {
AppendPersonNamesStrategy strategy = new AppendPersonNamesStrategy();
assertEquals(" and ", strategy.getDelimiter());
}

@ParameterizedTest(name = "separationBySpace={0}, expectedResult={1}")
@CsvSource({
"TRUE, ' '",
"FALSE, ' and '",
})
void testWithParam(boolean separationBySpace, String expectedResult) {
AppendPersonNamesStrategy strategy = new AppendPersonNamesStrategy(separationBySpace);
assertEquals(expectedResult, strategy.getDelimiter());
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
package org.jabref.gui.autocompleter;

import org.jabref.model.entry.Author;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;

import static org.junit.jupiter.api.Assertions.assertEquals;

public class PersonNameStringConverterTest {

/** The author. **/
private Author author;

@BeforeEach
void setUp() {
// set up auhtor's name
author = new Author("Joseph M.", "J. M.", "", "Reagle", "Jr.");
}

@ParameterizedTest(name = "autoCompFF={0}, autoCompLF={1}, autoCompleteFirstNameMode={2}, expectedResult={3}")
@CsvSource({
"TRUE, TRUE, ONLY_FULL, 'Reagle, Jr., Joseph M.'",
"TRUE, FALSE, ONLY_FULL, 'Joseph M. Reagle, Jr.'",
"FALSE, TRUE, ONLY_FULL, 'Reagle, Jr., Joseph M.'",
"FALSE, FALSE, ONLY_FULL, 'Reagle'",

"TRUE, TRUE, ONLY_ABBREVIATED, 'Reagle, Jr., J. M.'",
"TRUE, FALSE, ONLY_ABBREVIATED, 'J. M. Reagle, Jr.'",
"FALSE, TRUE, ONLY_ABBREVIATED, 'Reagle, Jr., J. M.'",
"FALSE, FALSE, ONLY_ABBREVIATED, 'Reagle'",

"TRUE, TRUE, BOTH, 'Reagle, Jr., J. M.'",
"TRUE, FALSE, BOTH, 'J. M. Reagle, Jr.'",
"FALSE, TRUE, BOTH, 'Reagle, Jr., J. M.'",
"FALSE, FALSE, BOTH, 'Reagle'"
})
void testToStringWithoutAutoCompletePreferences(boolean autoCompFF, boolean autoCompLF, AutoCompleteFirstNameMode autoCompleteFirstNameMode, String expectedResult) {
PersonNameStringConverter converter = new PersonNameStringConverter(autoCompFF, autoCompLF, autoCompleteFirstNameMode);
String formattedStr = converter.toString(author);
assertEquals(expectedResult, formattedStr);
}

@ParameterizedTest(name = "shouldAutoComplete={0}, firstNameMode={1}, nameFormat={2}, expectedResult={3}")
@CsvSource({
"TRUE, ONLY_FULL, LAST_FIRST, 'Reagle, Jr., Joseph M.'",
"TRUE, ONLY_ABBREVIATED, LAST_FIRST, 'Reagle, Jr., J. M.'",
"TRUE, BOTH, LAST_FIRST, 'Reagle, Jr., J. M.'",

"TRUE, ONLY_FULL, FIRST_LAST, 'Joseph M. Reagle, Jr.'",
"TRUE, ONLY_ABBREVIATED, FIRST_LAST, 'J. M. Reagle, Jr.'",
"TRUE, BOTH, FIRST_LAST, 'J. M. Reagle, Jr.'",

"TRUE, ONLY_FULL, BOTH, 'Reagle, Jr., Joseph M.'",
"TRUE, ONLY_ABBREVIATED, BOTH, 'Reagle, Jr., J. M.'",
"TRUE, BOTH, BOTH, 'Reagle, Jr., J. M.'"
})
void testToStringWithAutoCompletePreferences(boolean shouldAutoComplete, AutoCompleteFirstNameMode firstNameMode, AutoCompletePreferences.NameFormat nameFormat, String expectedResult) {
AutoCompletePreferences preferences = new AutoCompletePreferences(shouldAutoComplete, firstNameMode, nameFormat, null, null);
PersonNameStringConverter converter = new PersonNameStringConverter(preferences);
String formattedStr = converter.toString(author);
assertEquals(expectedResult, formattedStr);
}
}
75 changes: 75 additions & 0 deletions src/test/java/org/jabref/gui/edit/ReplaceStringViewModelTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,75 @@
package org.jabref.gui.edit;

import java.util.ArrayList;
import java.util.List;

import javafx.beans.property.SimpleBooleanProperty;
import javafx.beans.property.SimpleStringProperty;

import org.jabref.gui.LibraryTab;
import org.jabref.model.database.BibDatabase;
import org.jabref.model.entry.BibEntry;
import org.jabref.model.entry.field.StandardField;
import org.jabref.model.entry.types.StandardEntryType;

import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.when;

public class ReplaceStringViewModelTest {

private final LibraryTab libraryTab = mock(LibraryTab.class);
private ReplaceStringViewModel viewModel;

@BeforeEach
void setUp() {
BibEntry entry = new BibEntry(StandardEntryType.Article)
.withField(StandardField.AUTHOR, "Shatakshi Sharma and Bhim Singh and Sukumar Mishra")
.withField(StandardField.DATE, "April 2020")
.withField(StandardField.YEAR, "2020")
.withField(StandardField.DOI, "10.1109/TII.2019.2935531")
.withField(StandardField.FILE, ":https\\://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=8801912:PDF")
.withField(StandardField.ISSUE, "4")
.withField(StandardField.ISSN, "1941-0050")
.withField(StandardField.JOURNALTITLE, "IEEE Transactions on Industrial Informatics")
.withField(StandardField.PAGES, "2346--2356")
.withField(StandardField.PUBLISHER, "IEEE")
.withField(StandardField.TITLE, "Economic Operation and Quality Control in PV-BES-DG-Based Autonomous System")
.withField(StandardField.VOLUME, "16")
.withField(StandardField.KEYWORDS, "Batteries, Generators, Economics, Power quality, State of charge, Harmonic analysis, Control systems, Battery, diesel generator (DG), distributed generation, power quality, photovoltaic (PV), voltage source converter (VSC)");

List<BibEntry> entries = new ArrayList<>();
entries.add(entry);
when(libraryTab.getSelectedEntries()).thenReturn(entries);
when(libraryTab.getDatabase()).thenReturn(new BibDatabase(entries));
viewModel = new ReplaceStringViewModel(libraryTab);
}

@ParameterizedTest(name = "findString={0}, replaceString={1}, fieldString={2}, selectOnly={3}, allFieldReplace={4}, expectedResult={5}")
@CsvSource({
"RandomText, ReplaceText, author, TRUE, FALSE, 0", // does not replace when findString does not exist in the selected field
"Informatics, ReplaceText, journaltitle, TRUE, FALSE, 1", // replace "Informatics" in the JOURNALTITLE field to "ReplaceText" in the BibEntry
"Informatics, ReplaceText, journaltitle, TRUE, TRUE, 1", // replace "Informatics" in the JOURNALTITLE field to "ReplaceText" in the BibEntry
"Informatics, ReplaceText, journaltitle, FALSE, FALSE, 1", // replace "Informatics" in the JOURNALTITLE field to "ReplaceText" in the BibEntry
"Informatics, ReplaceText, journaltitle, FALSE, TRUE, 1", // replace "Informatics" in the JOURNALTITLE field to "ReplaceText" in the BibEntry
"2020, 2021, date, TRUE, FALSE, 1", // only replace "2020" in the DATE field to "2021" in the BibEntry
"2020, 2021, date, FALSE, TRUE, 2", // replace all the "2020"s in the entries
"2020, 2021, date, FALSE, FALSE, 1", // only replace "2020" in the DATE field to "2021" in the BibEntry
"2020, 2021, date, TRUE, TRUE, 2", // replace all the "2020"s in the entries
"System, ReplaceText, title, FALSE, TRUE, 1", // replace "System" in all entries is case sensitive
"and, '', author, TRUE, FALSE, 2", // replace two "and"s with empty string in the same AUTHOR field
"' ', ',', date, TRUE, FALSE, 1" // replace space with comma in DATE field
})
void testReplace(String findString, String replaceString, String fieldString, boolean selectOnly, boolean allFieldReplace, int expectedResult) {
viewModel.findStringProperty().bind(new SimpleStringProperty(findString));
viewModel.replaceStringProperty().bind(new SimpleStringProperty(replaceString));
viewModel.fieldStringProperty().bind(new SimpleStringProperty(fieldString));
viewModel.selectOnlyProperty().bind(new SimpleBooleanProperty(selectOnly));
viewModel.allFieldReplaceProperty().bind(new SimpleBooleanProperty(allFieldReplace));
assertEquals(expectedResult, viewModel.replace());
}
}