-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes Jabref#7660 Unable to download some arXiv links if the "eprint" field is missing #7663
Conversation
1. Run EprintCleanup on a copy of the entry the ArXiv fetcher is fetching before getting arXiv id from the eprint field; 2. Add two test method. One finds full text with title containing colon and journal, while another finds full text with title containing colon and url.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow that was quick 🚀 . Code looks good to me! Thanks for your contribution.
@@ -116,6 +118,9 @@ public TrustLevel getTrustLevel() { | |||
} | |||
|
|||
private List<ArXivEntry> searchForEntries(BibEntry entry) throws FetcherException { | |||
entry = (BibEntry) entry.clone(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you clone the entry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do clean up on the original entry, its fields will be changed but I think we needn't change fields here because it is just a search.
It is your advice that makes me efficient! At the beginning I try to ignore colons in title to solve this problem but it seems not so good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
…om.tngtech.archunit-archunit-junit5-api-0.18.0 * upstream/main: Fix exception when searching (#7659) Fixes #7660 (#7663) Fix for issue 5850: Journal abbreviations in UTF-8 not recognized (#7639) Fix SSLHandshake Exception by using bypass (#7657) Fix for issue 7633: Unable to download arXiv pdfs if Title contains curly brackets (#7652) Fix#7195 partly Opacity of disabled icon-buttons
Fixes #7660
Brief summary
Problem
When finding full text, this BibTeX reference works:
But when
eprint
field is missing, no full text will be found:Solution
Since the title contains colon and arXiv uses colon to represent key and value, the title may be recognized mistakenly. So use other fields to get the eprint field to avoid this problem. Thanks to the advice from @tobiasdiez .
Screenshots
After fix:
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)