Fix for issue 7641: Wrong path to TeXstudio #7664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Apr 23, 2021
| } else { | ||
| programPath = Path.of(progFiles, programName + DEFAULT_EXECUTABLE_EXTENSION).toString(); | ||
| } | ||
| File program = new File(programPath); |
There was a problem hiding this comment.
You can use Files.exist(path)
Siedlerchr
requested changes
Apr 23, 2021
| } | ||
|
|
||
| progFiles = System.getenv("ProgramFiles"); | ||
| System.out.println(progFiles); |
There was a problem hiding this comment.
Probably a left over from debugging. If you need debug output use LOGGER.debug(...)
There was a problem hiding this comment.
emmm，I was too careless. Thanks for your suggestion!
|
Just some minor code changes, but otherwise lgtm! |
Siedlerchr
added
the
status: ready-for-review
Siedlerchr
approved these changes
Apr 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7641
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)Bug:
No matter where the extended applications are, the default path of them (taken texstudio as example) would be set as
C:\Program Files (x86)\TeXstudio\texstudio.exe.The way to fix:
I verify the existence of extended applications under related default path. If there is no
texstudio.exeunderC:\Program Files (x86)\TeXstudio\andC:\Program Files\TeXstudio\, the function detectProgramPath() will return String value "", namely the default path will remain unset.