-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring existing unit tests #7687
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
95694c8
transformed to parameterized tests
BShaq 2e154d4
refactor to parameterized tests
BShaq 467be29
moved object creation into setup to reduce test code duplication
BShaq 40cfca6
fixed checkstyle issues
BShaq b0bd5a5
Merge remote-tracking branch 'upstream/main' into a4-bs-t2
BShaq 64d6887
Moved setup up to field variable in AuthorsTest
BShaq d398206
Moved setup up to field variable in FirstPageTest
BShaq 792b9ab
removed not used import in AuthorsTest
BShaq 06d9441
Moved setup up to field variable in DOICheckTest
BShaq 021d595
refactored FileLinkTest into parameterized tests
BShaq 79472d2
refactored FirstPageTest into parameterized tests
BShaq 288bb81
Merge remote-tracking branch 'upstream/main' into a4-bs-t2
BShaq File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 25 additions & 25 deletions
50
src/test/java/org/jabref/logic/layout/format/DOICheckTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,38 +1,38 @@ | ||
package org.jabref.logic.layout.format; | ||
|
||
import java.util.stream.Stream; | ||
|
||
import org.jabref.logic.layout.LayoutFormatter; | ||
|
||
import org.junit.jupiter.api.Test; | ||
import org.junit.jupiter.params.ParameterizedTest; | ||
import org.junit.jupiter.params.provider.Arguments; | ||
import org.junit.jupiter.params.provider.MethodSource; | ||
|
||
import static org.junit.jupiter.api.Assertions.assertEquals; | ||
|
||
public class DOICheckTest { | ||
|
||
@Test | ||
public void testFormat() { | ||
LayoutFormatter lf = new DOICheck(); | ||
|
||
assertEquals("", lf.format("")); | ||
assertEquals(null, lf.format(null)); | ||
|
||
assertEquals("https://doi.org/10.1000/ISBN1-900512-44-0", lf.format("10.1000/ISBN1-900512-44-0")); | ||
assertEquals("https://doi.org/10.1000/ISBN1-900512-44-0", | ||
lf.format("http://dx.doi.org/10.1000/ISBN1-900512-44-0")); | ||
|
||
assertEquals("https://doi.org/10.1000/ISBN1-900512-44-0", | ||
lf.format("http://doi.acm.org/10.1000/ISBN1-900512-44-0")); | ||
private LayoutFormatter layoutFormatter = new DOICheck(); | ||
|
||
assertEquals("https://doi.org/10.1145/354401.354407", | ||
lf.format("http://doi.acm.org/10.1145/354401.354407")); | ||
assertEquals("https://doi.org/10.1145/354401.354407", lf.format("10.1145/354401.354407")); | ||
|
||
// Works even when having a / at the front | ||
assertEquals("https://doi.org/10.1145/354401.354407", lf.format("/10.1145/354401.354407")); | ||
|
||
// Obviously a wrong doi, will not change anything. | ||
assertEquals("10", lf.format("10")); | ||
@ParameterizedTest | ||
@MethodSource("provideDOI") | ||
void formatDOI(String formattedDOI, String originalDOI) { | ||
assertEquals(formattedDOI, layoutFormatter.format(originalDOI)); | ||
} | ||
|
||
// Obviously a wrong doi, will not change anything. | ||
assertEquals("1", lf.format("1")); | ||
private static Stream<Arguments> provideDOI() { | ||
return Stream.of( | ||
Arguments.of("", ""), | ||
Arguments.of(null, null), | ||
Arguments.of("https://doi.org/10.1000/ISBN1-900512-44-0", "10.1000/ISBN1-900512-44-0"), | ||
Arguments.of("https://doi.org/10.1000/ISBN1-900512-44-0", "http://dx.doi.org/10.1000/ISBN1-900512-44-0"), | ||
Arguments.of("https://doi.org/10.1000/ISBN1-900512-44-0", "http://doi.acm.org/10.1000/ISBN1-900512-44-0"), | ||
Arguments.of("https://doi.org/10.1145/354401.354407", "http://doi.acm.org/10.1145/354401.354407"), | ||
Arguments.of("https://doi.org/10.1145/354401.354407", "10.1145/354401.354407"), | ||
Arguments.of("https://doi.org/10.1145/354401.354407", "/10.1145/354401.354407"), | ||
Arguments.of("10", "10"), | ||
Arguments.of("1", "1") | ||
|
||
); | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please convert the whole class to paramterized tests