Fix for issue 5804: Rewrite ACM fetcher

[ruanych]

Fixes #5804

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

From issue #5804, ACM Fetcher needs to be rewritten, because of ACM website changes.
One solution is to get the DOI from the HTML results of the search page, then use the export interface to get the JSON format data, and finally parse them.

Search API: https://dl.acm.org/action/doSearch?AllField=<query_string>
Export API: https://dl.acm.org/action/exportCiteProcCitation?targetFile=custom-bibtex&format=bibTex&dois=<doi>,<doi>,...

What did I do:

1. Rewrited ACMPortalFetcher, added ACMPortalParser.
2. added Modified ACMPortalFetcherTest and ACMPortalParserTest.

Successfully get data from AMC Fetcher:

[Siedlerchr]

I think you can simplify this whole EntryType stuff, if you want too look up an enum key by the string value:
StandardEntryType.valueOf(...)
Or alternatively, use the guava equivalent https://guava.dev/releases/19.0/api/docs/index.html?com/google/common/base/Enums.html

[ruanych]

The problem here is that the entry of StandardEntryType uses big camelcase nomenclature, I can't directly use StandardEntryType.valueOf(...), or I need to find a good way from JabRef to deal with big camelcase format and all-caps dashed separation format conversion.

And some types of naming do not match exactly. For example, the API returns PAPER_CONFERENCE corresponding to the CONFERENCE of StandardEntryType.

[Siedlerchr]

Ah I understand, however, you can directly operate on the Enum, there is the possibility to use an EnumSet and you have an Optional to check for the type.
This approach is simpler and you don't need to create a new Map with the keys and values

       Optional<StandardEntryType> foundType  = EnumSet.allOf(StandardEntryType.class).stream().filter(type-> type.getDisplayName().equals(strType)).findAny(); 

[ruanych]

Optional<StandardEntryType> foundType  = EnumSet.allOf(StandardEntryType.class).stream().filter(type-> type.getDisplayName().equals(strType)).findAny(); 

This is invalid if the input string is ARTICLE

New version~

private StandardEntryType typeStrToEnum(String typeStr) {
    StandardEntryType type;
    if ("PAPER_CONFERENCE".equals(typeStr)) {
        type = StandardEntryType.Conference;
    } else {
        String upperUnderscoreTyeStr = CaseFormat.UPPER_UNDERSCORE.to(CaseFormat.UPPER_CAMEL, typeStr);
        type = Enums.getIfPresent(StandardEntryType.class, upperUnderscoreTyeStr).or(StandardEntryType.Article);
    }
    return type;
}

[Siedlerchr]

Overall this looks already good to me, just some mimor changes/improvements

[koppor]

Good job!

Thank you for creating tests!

Small comments on the tests itself.

[koppor]

Just remove the disabled lines

[ruanych]

fixed.

[koppor]

May I ask whether you committed that change?

[ruanych]

I have deleted these two lines

// see https://github.com/JabRef/jabref/issues/5804 
// set.add(new ACMPortalFetcher(importFormatPreferences));

do you mean I still need to delete this line?

// set.add(new GoogleScholar(importFormatPreferences));

But this is another Fetcher

[koppor]

Sorry, was too late. Everything allright! 🎉

[ruanych]

@Siedlerchr @koppor Thank you very much for your help and suggestions.
The above problem has been fixed, and I also updated some codes.

[koppor]

Thank you for the quick follow-up.

Some small nitpicks remain 😇

[koppor]

May I ask whether you committed that change?

[koppor]

Thank you for working on it! This brings JabRef a step forward!