Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change WM_CLASS to jabref #7858

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Change WM_CLASS to jabref #7858

merged 1 commit into from
Jul 1, 2021

Conversation

Siedlerchr
Copy link
Member

Fixes #7848

  • [] Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • [] Tests created for changes (if applicable)
  • [] Manually tested changed features in running JabRef (always required)
  • [] Screenshots added in PR description (for UI changes)
  • [] Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member Author

Can someone on linux test this branch=? https://builds.jabref.org/pull/7858/merge/

@koppor
Copy link
Member

koppor commented Jun 29, 2021

@JoKalliauer Could you download and try https://builds.jabref.org/pull/7858/merge/?

@calixtus
Copy link
Member

Tested with ARCH Linux with KDE 5.22 and it seems to work and to collect all instances in one symbol.

@Siedlerchr Siedlerchr merged commit fc54b2d into main Jul 1, 2021
@Siedlerchr Siedlerchr deleted the FixLinuxDesktop branch July 1, 2021 17:03
@JoKalliauer
Copy link
Contributor

@JoKalliauer Could you download and try https://builds.jabref.org/pull/7858/merge/?

The WM_Class is still "org.jabref.gui.JabRefMain"

Screenshot from 2021-07-02 10-53-51

Siedlerchr added a commit that referenced this pull request Jul 4, 2021
…kflow-for-slr-search

* upstream/main: (31 commits)
  New translations JabRef_en.properties (German) (#7868)
  Fix test "higherTrustLevelWins()" (#7866)
  Change WM_CLASS to jabref (#7858)
  [Bot] Update CSL styles (#7865)
  Add unit test to four test classes (#7651)
  Fix IEEE test (#7852)
  New Crowdin updates (#7859)
  Fix markdown syntax of ADRs
  add missing l10n (#7857)
  New Crowdin updates (#7847)
  Bump mockito-core from 3.11.1 to 3.11.2 (#7856)
  Bump checkstyle from 8.43 to 8.44 (#7855)
  Fix for issue #4652: Add Find Unlinked Files Filter based on Date (#7846)
  Fix for entering a backslash in the custom entry preview dialog (#7851)
  Fixed INSPIREFetcherTest
  Fixed TitleFetcherTest
  Ignore baeldung.com and tldrlegal.com from out link checks
  New Crowdin updates (#7845)
  New Crowdin updates (#7843)
  Refactoring and addition of unit tests (#7597)
  ...

# Conflicts:
#	src/main/resources/l10n/JabRef_en.properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change WM_CLASS from org.jabref.gui.JabRefMain to jabref
4 participants