Various improvements on JournalsTab in the preferences #7937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calixtus
added
the
status: ready-for-review
Siedlerchr
approved these changes
Jul 24, 2021
calixtus
changed the title
koppor
reviewed
Jul 28, 2021
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java
Outdated
Show resolved
Hide resolved
Siedlerchr
approved these changes
Jul 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of it are some simple changes to the JournalsTab to improve consistency in the UI.
Removed also the single new empty pseudoabbreviation, since it produced some bugs and I did not see a benefit (correct me if I'm wrong)
Before:
After:
Someday JournalTabViewModel really should be refactored.
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)