Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify global search and library name #8066

Merged
merged 7 commits into from
Sep 9, 2021
Merged

Simplify global search and library name #8066

merged 7 commits into from
Sep 9, 2021

Conversation

Siedlerchr
Copy link
Member

Fixes parts of #8054

Rely on Observable Magic and collect entries for each db context

Bildschirmfoto 2021-09-07 um 20 21 48

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Rely on Observable Magic and collect entries for each databsecontet
Copy link
Member

@calixtus calixtus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, some questions.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 9, 2021
@Siedlerchr Siedlerchr merged commit 24fb04f into main Sep 9, 2021
@Siedlerchr Siedlerchr deleted the fixGlobalSearch branch September 9, 2021 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants