Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some typos #8157

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Fix some typos #8157

merged 1 commit into from
Oct 18, 2021

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 17, 2021

While coding, I saw that IntelliJ marks some code comments as typos. This PR fixes that.

Additionally, one small code change to keep the variable declaration close to the usage.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

I remember that we had the policy that one shouldn't just contribute random code style fixes, but instead improving the code quality while fixing a bug or implementing a feature... :-P

@koppor
Copy link
Member Author

koppor commented Oct 18, 2021

I wanted to separate the code style things from the other PR as we discuss for a long time to gain acceptance. - I thought that #8158 takes longer to merge.

@calixtus calixtus merged commit 71327b8 into main Oct 18, 2021
@calixtus calixtus deleted the fix-typos branch October 18, 2021 19:38
Siedlerchr added a commit that referenced this pull request Oct 22, 2021
…idth

* upstream/main:
  Fix some typos (#8157)
  Removed two unused preference options (#8164)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants