Observable preferences F (GuiPreferences, Proxy and Remote)

[calixtus]

Follow up to #8165

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[tobiasdiez]

It's late so I might missing something obvious here, but: You create a new ProxyPreference object here and storeProxySettings only calls the set* methods. Since there are no bindings of that proxypreference object to JabRefPreferences, this will essentially do nothing?!

[calixtus]

You're missing something. I think.
storeProxyPreferences takes just the members one by one of the newly created object and stores them in the original preferences object, that was supplied by JabRefPreferences. See NetworkTabViewModel::storeProxySettings:

    private void storeProxySettings(ProxyPreferences newProxyPreferences) {
        if (!newProxyPreferences.equals(proxyPreferences)) {
            ProxyRegisterer.register(newProxyPreferences);
        }

        proxyPreferences.setUseProxy(newProxyPreferences.shouldUseProxy());
        proxyPreferences.setHostname(newProxyPreferences.getHostname());
        proxyPreferences.setPort(newProxyPreferences.getPort());
        proxyPreferences.setUseAuthentication(newProxyPreferences.shouldUseAuthentication());
        proxyPreferences.setUsername(newProxyPreferences.getUsername());
        proxyPreferences.setPassword(newProxyPreferences.getPassword());
    }

The reason for creating a new preferences object here is to keep the test proxy button.

[tobiasdiez]

Okay thanks, I missed that indeed.

[Siedlerchr]

l10n fails:

>Remote server port
  
  1. CHECK IF THE KEY IS REALLY NOT USED ANYMORE
  2. REMOVE THESE FROM THE ENGLISH LANGUAGE FILE
   ==> expected: <[]> but was: <[Remote server port]>

[calixtus]

Thanks, just started IntelliJ a second ago to fix it, but you were quicker. :-)