-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include all standard columns with citationkey when exporting to old OpenOffice Calc format #8176
Conversation
…penOffice Calc format
Hey, thanks for the pr. I think this fix will be a great improvement! Please note that there is already a major refactor of the oo-interface in our backlog. Please take a look into it, so yours and the other one work fine together. |
@calixtus this is completely unrelated to the other open office integration. This is solely an exporter |
Oh i see, thanks. The |
I will handle |
Codewise looks already good, it would be cool to add a test for it. I think at least for the generated XML it should be possible. Have a look at the Docbook5ExporterTest, it uses the XMlUnit testing framework |
Thanks, I'll have a look, although I've never written tests before I'll see how that would go. |
content.xml should be enough, if the code comment is still right, then the meta.xml and manifest are just already existing files that are just copied over. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks
lgtm from my side as well. Can you please add a changelog entry as well? |
Thank you, I've added an entry in the Changed section |
Fixes #8141
Changes made:
FieldFactory.getStandardFieldsWithCitationKey()
OOCalcDatabase.java
NOTE: I didn't include fields with custom names
I have opened a draft PR because I noticedOpenDocumentRepresentation
(used to export OpenDocument spreadsheet), having the same problems asOOCalcDatabase
, I wanted to ask if fixingOpenDocumentRepresentation
should have its own PR or it's ok to include it in this one.Screenshot for the exported document in OpenOffice 4.1.11, Windows 11
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)