Fix "Library has changed externally" with CRLF markers

[koppor]

Fixes #4877

When a user had CRLF configured as line ending and stored a multiline field (such as comment), JabRef always complained with "the library has been modified externally". See #4877 (comment) for an MWE.

This PR fixes it and also refines the duplicate checker itself.

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[wujastyk]

JabRef 5.4--2021-11-15--6293196
Linux 5.11.0-40-generic amd64
Java 16.0.2
JavaFX 17.0.1+1

Just had this again :-(

1. Typed in a new article entry (image 1 below)
2. Immediately got the "library has been modified" message
3. Clicked "Review Changes" then "Mark All" and got image 2 below, that shows zero visible changes in the title.
4. Ground my teeth for a while, then moved on. :-)

Image 1

Image 2

[Siedlerchr]

I also could reproduce this by copy pasting an abstract. I guess it's related to multiline fields. Will check this. Maybe something has changed there

[Siedlerchr]

@wujastyk Can you please test the newest version again? We noticed that there was an error in our deployment process and so the new version with the fixes did not upload

[wujastyk]

I'd wonder about the long gap since the last version 🙂. I'll report again later today.

[wujastyk]

JabRef 5.4--2021-11-29--217f902
Linux 5.4.0-91-generic amd64
Java 16.0.2
JavaFX 17.0.1+1

There have been fewer cases, but I had another one just now, while adding a new book entry. The entry was uncomplicated. There was a question mark in the title. Could that be it?

@Book{jenk-1999,
  author    = {Keith Jenkins},
  date      = {1999},
  location  = {London and New York},
  publisher = {Routledge},
  title     = {Why History? Ethics and Postmodernity},
}

Here's the screenshot of the first error message:

And here's the "review changes" screenshot. There are no visible differences.

[koppor]

I reopened the issue and commented there --> #4877 (comment)

Issue reopened. Hoping, I will find some time this year.

[JoKalliauer]

@wujastyk

Do you write the entire entry by keyboard, or did you copy it from bib or from PDF? Copying Text from PDF can imho sometimes lead that you copy some non-standard character (not-visible character, special version of some kind of white-space,...).

Is the message always related to the last attribute? Maybe changes, which follow after the book-entry are related to the last attribute in the book-entry?

Is the error reproducible? (If so, how?)

[wujastyk]

I typed it from the keyboard.

The last attribute idea is a good one. I'll keep an eye out for this in future.

Reproducible, no, which is so annoying.

[wujastyk]

JabRef 5.4--2021-11-28--69467d3
Linux 5.4.0-90-generic amd64
Java 16.0.2
JavaFX 17.0.1+1

Oh, that's interesting. I typed the Jenkins entry (above) by hand, pressed save, and got the "library has been modified" message.

And I've been able to repeat this several times.

1. Open the bib file (^N),
2. type the Jenkins entry,
3. click the save icon.
4. Get "mod" message.

The mod message does not appear if I type the entry without the question-mark in the title.
But I if I just type the title "Why?" then the mod message also does not appear.

[Siedlerchr]

@wujastyk Did you use the "New entry " -> Book or did you first insert the "article" and modified the bibtex source?

[wujastyk]

I did the former, "new entry / book".

[wujastyk]

I am again thinking about having JR open on two machines, sharing the db via Dropbox. I'll try some tests later today.