Fix issues with writing metadata to pdfs

CHANGELOG.md

@@ -75,6 +75,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We fixed an issue where an exception would occur when clicking on a DOI link in the preview pane [#7706](https://github.com/JabRef/jabref/issues/7706)
 - We fixed an issue where XMP and embedded BibTeX export would not work [#8278](https://github.com/JabRef/jabref/issues/8278)
 - We fixed an issue where the XMP and embedded BibTeX import of a file containing multiple schemas failed [#8278](https://github.com/JabRef/jabref/issues/8278)
+- We fixed an issue where writing embedded BibTeX import fails due to write protection or bibtex already being present [#8332](https://github.com/JabRef/jabref/pull/8332)
 
 ### Removed
 

src/main/java/org/jabref/logic/exporter/EmbeddedBibFilePdfExporter.java

@@ -15,6 +15,7 @@
 import org.jabref.logic.bibtex.BibEntryWriter;
 import org.jabref.logic.bibtex.FieldWriter;
 import org.jabref.logic.bibtex.FieldWriterPreferences;
+import org.jabref.logic.l10n.Localization;
 import org.jabref.logic.util.OS;
 import org.jabref.logic.util.StandardFileType;
 import org.jabref.logic.util.io.FileUtil;
@@ -91,16 +92,28 @@ private void embedBibTex(String bibTeX, Path file, Charset encoding) throws IOEx
                 }
             }
 
+            PDComplexFileSpecification fileSpecification;
+            if (names.containsKey(EMBEDDED_FILE_NAME)) {
+                fileSpecification = names.get(EMBEDDED_FILE_NAME);
+            } else {
+                fileSpecification = new PDComplexFileSpecification();
+            }
             if (efTree != null) {
-                PDComplexFileSpecification fileSpecification = new PDComplexFileSpecification();
-                fileSpecification.setFile(EMBEDDED_FILE_NAME);
                 InputStream inputStream = new ByteArrayInputStream(bibTeX.getBytes(encoding));
+                fileSpecification.setFile(EMBEDDED_FILE_NAME);
                 PDEmbeddedFile embeddedFile = new PDEmbeddedFile(document, inputStream);
                 embeddedFile.setSubtype("text/x-bibtex");
                 embeddedFile.setSize(bibTeX.length());
                 fileSpecification.setEmbeddedFile(embeddedFile);
 
-                names.put(EMBEDDED_FILE_NAME, fileSpecification);
+                if (!names.containsKey(EMBEDDED_FILE_NAME)) {
+                    try {
+                        names.put(EMBEDDED_FILE_NAME, fileSpecification);
+                    } catch (UnsupportedOperationException e) {
+                        throw new IOException(Localization.lang("File '%0' is write protected.", file.toString()));
+                    }
+                }
+
                 efTree.setNames(names);
                 nameDictionary.setEmbeddedFiles(efTree);
                 document.getDocumentCatalog().setNames(nameDictionary);

src/main/resources/l10n/JabRef_en.properties

@@ -916,6 +916,7 @@ Writing\ metadata\ for\ selected\ entries...=Writing metadata for selected entri
 Writing\ metadata...=Writing metadata...
 
 Embed\ BibTeXEntry\ in\ PDF.=Embed BibTeXEntry in PDF.
+File\ '%0'\ is\ write\ protected.=File '%0' is write protected.
 Write\ BibTeXEntry\ as\ XMP\ metadata\ to\ PDF.=Write BibTeXEntry as XMP metadata to PDF.
 Write\ BibTeXEntry\ metadata\ to\ PDF.=Write BibTeXEntry metadata to PDF.
 Write\ metadata\ to\ PDF\ files=Write metadata to PDF files