Support CrossRef in CSL styles #8454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #7378 Add new test Fix existing test
Siedlerchr
added
the
status: ready-for-review
|
Failing fetcher test are not relevant (RFC the url format changed) |
koppor
requested changes
Jan 23, 2022
src/main/java/org/jabref/logic/citationstyle/CitationStyleGenerator.java
Show resolved
Hide resolved
src/main/java/org/jabref/logic/citationstyle/CitationStyleGenerator.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/citationstyle/CitationStyleGeneratorTest.java
Outdated
Show resolved
Hide resolved
todo need db context
Siedlerchr
removed
the
status: ready-for-review
* upstream/main: Bump h2-mvstore from 2.0.206 to 2.1.210 in /buildSrc (#8458) Bump mariadb-java-client from 2.7.4 to 2.7.5 (#8457) Bump com.github.andygoossens.modernizer from 1.6.1 to 1.6.2 (#8459) Bump mockito-core from 4.2.0 to 4.3.0 (#8460) Bump xmlunit-matchers from 2.8.3 to 2.8.4 (#8461) Improve error handling for browser extension (#8432)
* upstream/main: Made search button in Web search wider. Also skewed side panel titles to the left (#8463)
add tests for issue and number modify example tobe able to distinguish between issue and number
fix tests
Siedlerchr
added
the
status: ready-for-review
koppor
requested changes
Jan 27, 2022
| factory.createMenuItem(StandardActions.COPY_CITATION_RTF, new CopyCitationAction(CitationStyleOutputFormat.RTF, dialogService, stateManager, clipBoardManager, taskExecutor, previewPreferences)), | ||
| factory.createMenuItem(StandardActions.COPY_CITATION_ASCII_DOC, new CopyCitationAction(CitationStyleOutputFormat.ASCII_DOC, dialogService, stateManager, clipBoardManager, taskExecutor, previewPreferences)), | ||
| factory.createMenuItem(StandardActions.COPY_CITATION_XSLFO, new CopyCitationAction(CitationStyleOutputFormat.XSL_FO, dialogService, stateManager, clipBoardManager, taskExecutor, previewPreferences))); | ||
| copyCitationMenu.getItems().add( |
There was a problem hiding this comment.
Can we add COPY_CITATION_HTML? - This is IMHO a proper replacement for RTF, ASCII_DOC, XSLFO
factory.createMenuItem(StandardActions.COPY_CITATION_HTML, new CopyCitationAction(CitationStyleOutputFormat.HTML, dialogService, stateManager, clipBoardManager, taskExecutor, previewPreferences)),
There was a problem hiding this comment.
See two lines above, HTML has been already available
There was a problem hiding this comment.
OK - I did not expect that being present in a different menu.
Can we merge it into one? The current sub menu has only one item!
New:
ThiloteE
reviewed
Jan 28, 2022
There was a problem hiding this comment.
@Siedlerchr How can i help you? Sorry, at least ~90% of this pull request is something i would need to look up, though. It is above my current skill level.
| BibEntry entry = new BibEntry(StandardEntryType.Article); | ||
| entry.setField(StandardField.AUTHOR, "Last, First and\nDoe, Jane"); | ||
| entry.setField(StandardField.ISSUE, "7"); | ||
| entry.setField(StandardField.ISSUE, "28"); |
There was a problem hiding this comment.
Is this a typo? Issue x2. Above it says "withIssueAndNumber".
There was a problem hiding this comment.
Oh thanks for spotting! This was not intended.
There was a problem hiding this comment.
As you can now see at the tests, the bibtex number gets now rendered as Art no. This PR is the preparation for the other issue, as we now have complete database information
| void testBiblatexWitNumber() { | ||
| BibEntry entry = new BibEntry(StandardEntryType.Article); | ||
| entry.setField(StandardField.AUTHOR, "Last, First and Doe, Jane"); | ||
| entry.setField(StandardField.NUMBER, "7"); |
There was a problem hiding this comment.
At the top you used "3" for number. Maybe here too?
* upstream/main: Update to Javafx 17.02 (#8470)
Siedlerchr
added a commit
that referenced
this pull request
Jan 28, 2022
* upstream/main: (24 commits) Support CrossRef in CSL styles (#8454) Update FUNDING.yml (#8473) Update to Javafx 17.02 (#8470) Made search button in Web search wider. Also skewed side panel titles to the left (#8463) Bump h2-mvstore from 2.0.206 to 2.1.210 in /buildSrc (#8458) Bump mariadb-java-client from 2.7.4 to 2.7.5 (#8457) Bump com.github.andygoossens.modernizer from 1.6.1 to 1.6.2 (#8459) Bump mockito-core from 4.2.0 to 4.3.0 (#8460) Bump xmlunit-matchers from 2.8.3 to 2.8.4 (#8461) Improve error handling for browser extension (#8432) New Crowdin updates (#8451) Fix library tab exception when saving prefs (#8450) Rename Groups interface into Groups (#8449) New Crowdin updates (#8445) update snap url Update bug_report.yml for 5.5 Show development information\n\n+semver: minor Release v5.5 Update journal abbrev list New Crowdin updates (#8439) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7378 and also provides groundwork for any fix regarding #8372
Removed copy of CSL to ASCIIDOC, RTF and XSL_FO as these are no longer supported
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)