Fix for Indexing stopping while having library modification

[GabrielZardoya]

Fixes issue #8420. Code follows suggested change in original issue by @tobiasdiez: makes database context a constructor for IndexingTabManager, has IndexingTabManager listen for filename changes and updates title using logic from updateTabTitle method in LibraryTab. Feel free to ask me any questions or make/propose changes as needed.

fixes #8420

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

You said you encountered some issues, can you explain it a bit better.

[GabrielZardoya]

You said you encountered some issues, can you explain it a bit better.

I mean it didn't pass some test cases in gradlew check. It looks like it works to solve the problem running it manually, though I'm assuming since there are failed test cases it's breaking something else I'm not aware of.

It fails these tests in particular:

• testPortAlreadyInUse()
• fieldDoesNotAcceptUmlauts()
• NonUTF8EncodingCheckerTest()
• studyResultsPersistedCorrectly()
• fetcherResultsPersistedCorrectly()
• mergedResultsPersistedCorrectly()

[Siedlerchr]

They are not relevant to your changes and you can ignore them. If the tests on the CI pass its fine. (fetcher test can be ignored if you didn't change a fetcher)

[GabrielZardoya]

They are not relevant to your changes and you can ignore them. If the tests on the CI pass its fine. (fetcher test can be ignored if you didn't change a fetcher)

OK, thanks for informing me. It should be good then to review, if you have any issues or questions let me know.

[Siedlerchr]

Okay, then if your PR is ready then remove the WIP and it would be nice if you could explain your changes a bit here in the PR description what the fix is/how it works.

[GabrielZardoya]

Okay, then if your PR is ready then remove the WIP and it would be nice if you could explain your changes a bit here in the PR description what the fix is/how it works.

OK, let me know if you have any other questions or recommendations.

[btut]

LGTM, thanks!

[btut]

@tobiasdiez could you check if this solves your issue?

[tobiasdiez]

Generally looks good to me. One suggestion to improve the code a bit. Please also add a change log entry. Otherwise good to go from my side.

[GabrielZardoya]

Generally looks good to me. One suggestion to improve the code a bit. Please also add a change log entry. Otherwise good to go from my side.

I updated CHANGELOG.md and committed your suggestion to the PR. Let me know if there is anything else you would recommend.

[tobiasdiez]

Thanks! There are still some merge conflicts. Could you please take care of them as well?

[GabrielZardoya]

Thanks! There are still some merge conflicts. Could you please take care of them as well?

Alright, I believe all the conflicts should be fixed now. Checked to make sure it still fixes the issue and it does after some modifications. Let me know if there is anything you would like to change with the new revisions.

[Siedlerchr]

I had to revert the commit because after opening a file the library tab shows untitled! /File open recent
@GabrielZardoya Please look into this again.