Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add encoding detection (and pin export to UTF-8) #8506

Merged
merged 35 commits into from
Mar 9, 2022
Merged

Add encoding detection (and pin export to UTF-8) #8506

merged 35 commits into from
Mar 9, 2022

Conversation

koppor
Copy link
Member

@koppor koppor commented Feb 19, 2022

This is a follow-up to #8238.

This PR adds the feature to detect the encoding of a file. JabRef relies on the % Encoding: statement of a file. What if that statement is not present? JabRef 5.5 and 5.6 used "UTF-8"; versions before used the one in the user's preferences. Both approaches are not that reliable.

The PR also removes the feature of custom encoding for exporting - and inlines "UTF-8" settings (which were distributed throughout the code).

New general preferences:

grafik

It looked as follows before:

grafik
gi

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor marked this pull request as draft February 19, 2022 00:59
Siedlerchr and others added 10 commits February 19, 2022 13:10
# Conflicts:
#	src/main/java/module-info.java
#	src/test/java/org/jabref/logic/xmp/XmpUtilReaderTest.java
* upstream/main:
  Add initial telemetry development documentation (#8530)
  Add existing "Remote storage" to index
  Disable telemetry client due to incompatibilites with jakarta (#8526)
Java 17 uses id now for Indonesian
Remove obsolete crowdin mapping
Fix checkstyle
Even if it's UTF 8 it returned ISO, probably because it's not having a BOM header
 so we check for utf8 and utf16 manually
* upstream/main:
  issue(8448): allow URL with + sign in entry tabs (#8508)
@Siedlerchr Siedlerchr marked this pull request as ready for review February 26, 2022 13:34
@Siedlerchr
Copy link
Member

Only failing test is the StyleLoader test, but that apparently fails randomly

* upstream/main:
  Add Missing Fillers/Extractors for Supported Fields and Support Day Conversion (#8531)
  Bump checkstyle from 9.3 to 10.0 (#8544)
  Fix online link detection in entry editor (#8514)
  Add some JavaDoc to Fetchers
  Support two argument form of \abx@aux@cite macro in DefaultAuxParser (#8549)
  Bump guava from 31.0.1-jre to 31.1-jre (#8543)
  Bump org.beryx.jlink from 2.24.4 to 2.25.0 (#8548)
  Bump postgresql from 42.3.2 to 42.3.3 (#8546)
  Bump richtextfx from 0.10.7 to 0.10.9 (#8547)
  Bump archunit-junit5-engine from 0.22.0 to 0.23.1 (#8545)
  Bump actions/checkout from 2 to 3 (#8542)
  Squashed 'buildres/csl/csl-styles/' changes from eb97405..8f69d4e
  Bump classgraph from 4.8.139 to 4.8.141 (#8535)
  Bump archunit-junit5-api from 0.22.0 to 0.23.1 (#8536)

# Conflicts:
#	src/test/java/org/jabref/logic/xmp/XmpUtilReaderTest.java
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 9, 2022
@koppor koppor merged commit 75df9a3 into main Mar 9, 2022
@koppor koppor deleted the fix-changed branch March 9, 2022 23:20
Siedlerchr added a commit that referenced this pull request Mar 13, 2022
* upstream/main:
  Update RemoteSetupTest.java, adding eq() function from mockito (#8561)
  readd encoding after merge
  Open office refactor finalization (formerly OObranch J cleanup) (#7795)
  Revert "Refine documentation (#8551)" (#8560)
  Refine documentation on logging (#8550)
  Revert "Refine documentation (#8551)" (#8559)
  Refine documentation (#8551)
  New Crowdin updates (#8557)
  New Crowdin updates (#8553)
  Fix missing metadata in BibDatabaseContext (#8556)
  Add encoding detection (and pin export to UTF-8) (#8506)
  Add Missing Fillers/Extractors for Supported Fields and Support Day Conversion (#8531)
  Bump checkstyle from 9.3 to 10.0 (#8544)
  Fix online link detection in entry editor (#8514)
  Add some JavaDoc to Fetchers
  Support two argument form of \abx@aux@cite macro in DefaultAuxParser (#8549)
@koppor koppor mentioned this pull request Jul 9, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants