Add a few cleanup formatters #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
added
type: feature
status: ready-for-review
Readd functionality "Remove double braces around BibTeX fields when loading" (which was removed in c2928d2) as a formatter.
tobiasdiez
force-pushed
the
addCleanup
branch
from
3803323 to
aa91be1
Compare
| @@ -25,11 +25,6 @@ public void testBasic() { | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Keep and add (expected...)?
There was a problem hiding this comment.
Ahh, now I saw the next file... ;-)
|
👍 Now I only want a formatter that removes ' around fields. A colleague does that as that also keeps the casing... However, I guess it may be a rare use case for the general public... |
|
👍 nice. I especially like the data driven test of all formatters! Good idea. |
|
LGTM 👍 |
simonharrer
added a commit
that referenced
this pull request
Feb 22, 2016
Add a few cleanup formatters
This was referenced Feb 22, 2016
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following formatters, which are suitable for the new save actions functionality #821:
loading" but was removed from the parser in c2928d2.
Also add some tests for all formatters.