Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing search index dir #8581

Merged
merged 1 commit into from
Mar 17, 2022
Merged

Fix missing search index dir #8581

merged 1 commit into from
Mar 17, 2022

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Mar 17, 2022

Fixes #8579

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 17, 2022
@Siedlerchr Siedlerchr merged commit 6ebb56f into main Mar 17, 2022
@Siedlerchr Siedlerchr deleted the fixMissingDir branch March 17, 2022 17:57
Siedlerchr pushed a commit that referenced this pull request Mar 26, 2022
* Design the preference section for adding custom SSL certificates

* Inject custom certificates FXML views into the controller

* Delete unused import

* Allow for enabling or disabling custom certificates

* Use LocalDate instead of LocalDateTime for tracking certificate validity

* Populate CustomCertificateViewModel with data from SSLCertificate

- Added a method to map X509Certificate to SSLCertificate

* Setup cell factory and populate the table with dummy data

* Add '.cer' to StandardFileType

* Open file explorer on 'Add certificate' clicked

* Copy JDK 17 truststore into project resources

* Bump JavaFX from 17.0.2 to 18 (#8577)

* Bump JavaFX from 17.0.2 to 18

* Remove mac os hack for maintable
Copy Preview content and not entry

Co-authored-by: Siedlerchr <siedlerkiller@gmail.com>

* Fix missing search index dir (#8581)

Fixes #8579

* Log user added certificates information

* Add an alias property to SSLCertificate that is generated randomly

- A keystore contains a list of certificate entries, each of which is identified by a unique alias. For now, I'll generate aliases at random, but in the future, it would be better if users entered them.

* Create TrustStoreManager for truststore manipulation

* Add SSLPreferences

* Set custom certificate preferences defaults

* Persist 'useCustomCertificate' boolean preference

* Use certificate thumbprint as an alias

For the alias to be useful it has to be unique, I thought about using the serial number, but it is only unique for the CA, so I created a hash of all fields in the certificate

* Delete dummy certificates and use real imported certificate information

* Move certificate version formatting logic to the view

* Move TrustStoreManager from GUI to Logic

* Use Integer to store version instead of primitive int

* Persist thumbprint, version, validFrom and validTo columns

* Use localized strings

* Fix failing test

* Persist all certificate columns

* Load truststore path from preferences

* Deprecate bypassSSLVerification() and delete its usage

- I didn't delete it because users might want to enable ssl bypassing from SSL configuration

* Set truststore path at startup

* Store truststore path in preference

* Update CHANGELOG.md

* Add an icon to 'Add certificate' button

* Update truststore file on save preference

* Clear all custom certificates from the truststore at preference reset

* Use truststore as the single source of truth

* Show warning dialog on attempting to add a duplicate certificate

- Minor refactoring
- Added certificate deletion to UI
- i18n

* Stop allowing for toggling custom certificates usage

* Delete SSL certificates

* Fix failing test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
1 participant