Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve key generation #8641

Merged
merged 4 commits into from
Apr 4, 2022
Merged

Improve key generation #8641

merged 4 commits into from
Apr 4, 2022

Conversation

koppor
Copy link
Member

@koppor koppor commented Apr 4, 2022 •
edited
Loading

Follow up to #8361; fixes #8642

refs #8406

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Apr 4, 2022
@Siedlerchr Siedlerchr merged commit 90276f3 into main Apr 4, 2022
@Siedlerchr Siedlerchr deleted the follow-up-checkkeygen branch April 4, 2022 21:50
@ThiloteE ThiloteE mentioned this pull request Apr 4, 2022
Open
2 tasks
Siedlerchr added a commit that referenced this pull request Apr 5, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into lucenceUpgrade
4dcb7f8 
* upstream/main:
  Remove obsolete comments
  Improve key generation (#8641)
  Refine search code (#8636)
  Fix import entry by id does not generate citation key (#8361)
  Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637)
  Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638)
  GitBook: [#57] test
  Citation keygen: Return vonPart if lastName is empty (#8634)
  Ensure SSL truststore is present at startup (#8631)
  Squashed 'buildres/csl/csl-styles/' changes from 6a7b708..21e2177 (#8632)
  Add more tests for FieldChange Class (#8614)
Siedlerchr added a commit that referenced this pull request Apr 5, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into dependabot/gradle/c…
cce5a92 
…om.github.tomtung-latex2unicode_2.12-0.3.0

* upstream/main:
  Remove obsolete comments
  Improve key generation (#8641)
  Refine search code (#8636)
  Fix import entry by id does not generate citation key (#8361)
  Update Gradle Wrapper from 7.4.1 to 7.4.2. (#8637)
  Bump hmarr/auto-approve-action from 2.1.0 to 2.2.0 (#8638)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
duplicateFinder status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Duplicate check of keygenerator during merge dialogue after importing and pasting entry
3 participants
@koppor @Siedlerchr @ThiloteE