Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes koppor/jabref#521 - Allow to drag&drop selected bib entries to other library tabs #8982

Merged
merged 7 commits into from
Jul 18, 2022

Conversation

GNAQ
Copy link
Contributor

@GNAQ GNAQ commented Jul 15, 2022

Fixed JabRef#521

by adding a new feature that allows to drag selected entries, and drop them to other opened inactive bib library tabs.

Behavior Description:

Now when dragging selected entries in main table, JabRef allows user to drop it on another opened library tab, and this item will be copied and added to the dropped library accordingly. Drop to current active tab is disallowed. If there're potential duplicated entries, JabRef will ask user to confirm and choose copy behavior (similar to ctrl-c/v copy and paste).

Screenshots for UI changes:

screenshot.gif

Checklist / TODOs :

  • Code implement of this new feature
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@GNAQ GNAQ marked this pull request as ready for review July 15, 2022 15:26
@ThiloteE ThiloteE added the ui label Jul 15, 2022
@ThiloteE ThiloteE changed the title Fix issue koppor/jabref#521 (Add feature: allow drag&drop from selected bib entries to other library tabs) Fixes koppor/jabref#521 - Allow to drag&drop selected bib entries to other library tabs Jul 16, 2022
@ThiloteE ThiloteE added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 16, 2022
@Siedlerchr Siedlerchr added this to the v5.7 milestone Jul 16, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this PR! Codewise looks already good to me.
Before merging, a second maintainer needs to review your code as well

…ription)

Co-authored-by: Christoph <siedlerkiller@gmail.com>
@GNAQ
Copy link
Contributor Author

GNAQ commented Jul 17, 2022

thanks for this PR! Codewise looks already good to me. Before merging, a second maintainer needs to review your code as well

Thank you for your kindly review!

@koppor
Copy link
Member

koppor commented Jul 18, 2022

Thank you for the PR! We have a small nitpick that t should be named tab (to have a bit more readable local variable name).

We could not update it for ourselves, because editing by maintainers is disabled:

grafik

We merge nevertheless and will rename later (at some time ^^).

Thank you for the PR!

@koppor koppor merged commit 6d6423c into JabRef:main Jul 18, 2022
@koppor
Copy link
Member

koppor commented Jul 18, 2022

Rename happened at #8989

Siedlerchr added a commit to zkl-ai/jabref that referenced this pull request Jul 19, 2022
…failure-dialog

* upstream/main:
  Reworded t in pr (JabRef#8989)
  Fixed checkstyle (JabRef#8990)
  Fix RfcFetcherTest (JabRef#8988)
  Fixes JabRef#521 - Allow to drag&drop selected bib entries to other library tabs (JabRef#8982)

# Conflicts:
#	src/main/java/org/jabref/gui/maintable/MainTable.java
#	src/test/java/org/jabref/logic/importer/fetcher/JstorFetcherTest.java
Siedlerchr added a commit to Ognimalf/jabref that referenced this pull request Jul 29, 2022
* upstream/main:
  Autosave folder and checkbox is remembered (JabRef#9000)
  New Crowdin updates (JabRef#8999)
  Sync group view mode and main table (JabRef#8993)
  Bump unoloader from 7.3.4 to 7.3.5 (JabRef#8996)
  Bump libreoffice from 7.3.4 to 7.3.5 (JabRef#8997)
  Bump java-diff-utils from 4.11 to 4.12 (JabRef#8998)
  Fix external group metadata changes are not merged (JabRef#8994)
  New Crowdin updates (JabRef#8995)
  Reworded t in pr (JabRef#8989)
  Fixed checkstyle (JabRef#8990)
  Fix RfcFetcherTest (JabRef#8988)
  Fixes JabRef#521 - Allow to drag&drop selected bib entries to other library tabs (JabRef#8982)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drag'n'drop to another library should be possible
5 participants