-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Citavi Importer - Import all knowledge items #9043
Conversation
Filter out empty strings and replace quot
2d5ef1d
to
4ae2d73
Compare
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Christoph <siedlerkiller@gmail.com>
src/main/java/org/jabref/logic/importer/fileformat/CitaviXmlImporter.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fileformat/CitaviXmlImporterTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/jabref/logic/importer/fileformat/CitaviXmlImporterTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As co-author, I like it 😇
I am waiting on feedback from ray-carpenter, so let's wait with merging a bit |
…ref into followUpCitativKnowledgeItems * 'followUpCitativKnowledgeItems' of github.com:JabRef/jabref:
I've now included the quotation index and the type of the quotation as well. Based on the mapping: |
src/main/java/org/jabref/logic/importer/fileformat/CitaviXmlImporter.java
Show resolved
Hide resolved
I like. Future work should treat the quotation stuff as PDF highlights, shouldn't it? - This would enable "annotating" PDFs without altering the PDF. Similar as CloudRef does it. :) |
Yes, but we don't have a concept for storing pdf annotations in bibtex fields, they are just read and kept in memory while JabRef is open. |
We could create a YAML file - as we are going to do at #7160 (comment). |
* upstream/main: (31 commits) Citavi Importer - Import all knowledge items (JabRef#9043) Fixed table update in eft preferences (JabRef#9051) Keep EOL setting at backups (JabRef#9048) ExternalFileTypes singleton refactor (JabRef#9044) Fix dead link (JabRef#9047) Fix performance regresssion (JabRef#9045) Update javafx to 18.02 import citavi knowledge items (JabRef#9033) Fix .gitattributes for CHANGELOG.md [GSOC22] - B - Implement merging fields in the three way merge UI (JabRef#9022) [GSOC22] - A - Implement a fully functional three way merge UI (JabRef#8945) Change button label from "Return to JabRef" to "Return to library" (JabRef#9039) Bump postgresql from 42.4.0 to 42.4.1 (JabRef#9036) Bump org.javamodularity.moduleplugin from 1.8.11 to 1.8.12 (JabRef#9037) Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 (JabRef#9035) Bump slf4j-api from 2.0.0-alpha7 to 2.0.0-beta1 in /buildSrc (JabRef#9038) Update Gradle Wrapper from 7.5 to 7.5.1. (JabRef#9034) Refactor of DOI import failure dialog, import format reader and clipboard manager (JabRef#8839) Snapcraft and issue template Show development information\n\n+semver: minor ...
Filter out empty strings and replace quot
Follow up from #9033
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)