Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #9068: Fix capitalization after en-dash characters in title #9099

Closed
wants to merge 1 commit into from
Closed

Fix for #9068: Fix capitalization after en-dash characters in title #9099

wants to merge 1 commit into from

Conversation

Victor-Buendia
Copy link

Fixes #9068

Title case capitalizes after en-dash in title.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Victor-Buendia Victor-Buendia changed the title Fix capitalization after en-dash characters in title Fix for #9068: Fix capitalization after en-dash characters in title Aug 28, 2022
@calixtus
Copy link
Member

calixtus commented Aug 29, 2022

Hi @Victor-Buendia, thanks for your PR, which already looks very good. However, there are some issues I noticed on a first look:

  • Please resolve merge conflicts
  • please avoid unnecessary changes to linebrakes in comments. Depending whoever works on a file it would otherwise only go back and forth and back and forth. Please undo them.
  • we love parameterized tests. However, I believe the changes to the isiimportertest are wrong in this pr as it seems unrelated to the fixes in the title case formatter. Please put the changes to the isiimporter in another PR.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

title case may be no right when the en-dash exist in title
2 participants