Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Java Flight Recorder #9174

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Remove Java Flight Recorder #9174

merged 1 commit into from
Sep 25, 2022

Conversation

koppor
Copy link
Member

@koppor koppor commented Sep 23, 2022

This removes Java Flight Recorder

Java Flight Recorder requires a commercial license for use in production.
[...]
Java Flight Recorder (JFR) is a tool for collecting diagnostic and profiling data about a running Java application.

I think, we never used it on a user's side, so would remove it for our distribution.

On a case-per-case-basis, we (or some researchers) could include jdk.jfr back locally.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 23, 2022
@Siedlerchr
Copy link
Member

I thought the open jdk version is free to use

@koppor
Copy link
Member Author

koppor commented Sep 24, 2022

I thought the open jdk version is free to use

In case you have source for that? Maybe, its the client tooling accessing the JFR data. I don't use profiling tooling in my daily work with JabRef. I perceived that we as group do profiling "on demand" when we concentrate on memory consumption etc. For this case, we are free to re-use any module required to do that. - However, in 99,99% of the usages of JabRef, the modules is NOT used. Furthermore, using the module prevents us to switch to other JDKs. Not OpenJ9 and IMHO also not GraalVM. Further, removing the module makes the distrubtion size smaller and gains a (small) bit of performance.

@calixtus calixtus merged commit a618300 into main Sep 25, 2022
@calixtus calixtus deleted the remove-jdk-jfr branch September 25, 2022 18:31
Siedlerchr added a commit to LIM0000/jabref that referenced this pull request Oct 3, 2022
* upstream/main: (27 commits)
  Bump slf4j-api from 2.0.2 to 2.0.3 (JabRef#9207)
  Bump slf4j-api from 2.0.2 to 2.0.3 in /buildSrc (JabRef#9211)
  Add mappings on ModsImporter.java (JabRef#9193)
  Improve installation of java 18 in devcontainer (JabRef#9197)
  Fix missing title for "customize entry types" (JabRef#9198) (JabRef#9201)
  Squashed 'buildres/csl/csl-locales/' changes from b2afeb4d87..cb98d36691
  Squashed 'buildres/csl/csl-styles/' changes from 201e022..7bde3e4
  "Capitalize" capitalizes words after hyphens (JabRef#9186)
  Observable Preferences O (Language and FileHistory) (JabRef#9173)
  Fix jakarta annotation missing (JabRef#9183)
  Bump junit-platform-launcher from 1.9.0 to 1.9.1 (JabRef#9177)
  Bump WyriHaximus/github-action-wait-for-status from 1.6 to 1.7.1 (JabRef#9178)
  Bump junit-jupiter from 5.9.0 to 5.9.1 (JabRef#9180)
  Bump checkstyle from 10.3.3 to 10.3.4 (JabRef#9179)
  Bump slf4j-api from 2.0.1 to 2.0.2 (JabRef#9181)
  Bump slf4j-api from 2.0.1 to 2.0.2 in /buildSrc (JabRef#9182)
  Remove Java Flight Recorder (JabRef#9174)
  Fixes fetcher tests (JabRef#9175)
  Update afterburner to jakarta (JabRef#9168)
  Improve startup-behavior of pdf indexer (JabRef#9166)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants