Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP server for MS Office Word integration #9246

Closed
wants to merge 2 commits into from
Closed

Conversation

tobiasdiez
Copy link
Member

Adds HTTP server for Office integration. At the moment, it's only a prototype showing that we do have enough space in our module list to include the jdk.httpserver (which is unfortunatly not as dev-friendly as other solutions, but works fine).

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

See my otherPR koppor#628 for setting up a nice REST API

@tobiasdiez
Copy link
Member Author

@Siedlerchr the point here is that jdk.httpserver is small enough to be included while jetty/tomcat and (probably undertow) are too large. Thus, in the short term this seems to be our only option.

@koppor
Copy link
Member

koppor commented Oct 12, 2022

Sacrificing code maintainability because of a bug in the language environment 🙈

@tobiasdiez
Copy link
Member Author

It's not that terrible, just a bit more low-level and can be abstracted away. But yes, if that's what it takes to play around the annoying jdk bug but have a nice user experience, then I'm fine with it.

@Siedlerchr
Copy link
Member

We need to have SSL support enabled for the office addin

@ThiloteE ThiloteE changed the title Add HTTP server for Office integration Add HTTP server for MS Office Word integration Nov 18, 2022
@koppor
Copy link
Member

koppor commented Sep 3, 2023

Superseeded by #9748

@koppor koppor closed this Sep 3, 2023
@tobiasdiez tobiasdiez deleted the office-server branch September 4, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants