Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download from URL now automatically fills with URL in clipboard #9282

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Download from URL now automatically fills with URL in clipboard #9282

merged 5 commits into from
Oct 25, 2022

Conversation

Gpax971
Copy link
Contributor

@Gpax971 Gpax971 commented Oct 22, 2022

Autofills URL in clipboard when downloading from URL
Fixes JabRef#535

image

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Racheal7
Copy link
Contributor

Hi Griffith, it looks good.

@Gpax971 Gpax971 marked this pull request as ready for review October 23, 2022 07:14
Siedlerchr
Siedlerchr approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me!

@Siedlerchr Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers hacktoberfest-accepted labels Oct 23, 2022
@tobiasdiez tobiasdiez merged commit 7f2b602 into JabRef:main Oct 25, 2022
@koppor koppor mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When clicking on download file from URL, the URL in the clipboard should be filled in the field
4 participants
@Gpax971 @Racheal7 @Siedlerchr @tobiasdiez