Preview panel is now updated when an entry is cut/deleted #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good 👍 |
boceckts
added
status: ready-for-review
|
👍 |
1 similar comment
|
👍 |
|
Does the panel show up again when selecting another entry after deleting one? If so 👍 |
|
Yes, it does. |
|
We really should consider to implement an event system... |
tobiasdiez
added a commit
that referenced
this pull request
Mar 11, 2016
Preview panel is now updated when an entry is cut/deleted
|
👍 for the event system (maybe use the stuff that comes with google guava. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #936.
When an entry is cut/deleted the preview panel will be hidden due to the fact that no entry is selected anymore.