Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weird checkbox styling #9425

Merged
merged 1 commit into from
Dec 4, 2022
Merged

Fix weird checkbox styling #9425

merged 1 commit into from
Dec 4, 2022

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 4, 2022

Follow up to #9320

Previously
grafik

Now fixed:

grafik

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 4, 2022
@HoussemNasri
Copy link
Member

The menu button got a rounded style too. It probably happened by accident. It doesn't look that bad, but if you think it looks better with a sharp corner just include the menu-button style class.

image

Copy link
Member

@HoussemNasri HoussemNasri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Siedlerchr
Copy link
Member Author

Ah (that's one thing I cannot see under mac :-P )

@Siedlerchr Siedlerchr merged commit aeddfd0 into main Dec 4, 2022
@Siedlerchr Siedlerchr deleted the fixCheckboxStyling branch December 4, 2022 22:21
Siedlerchr added a commit that referenced this pull request Dec 5, 2022
* upstream/main:
  Bump slf4j-api from 2.0.4 to 2.0.5 (#9428)
  Bump archunit-junit5-api from 1.0.0 to 1.0.1 (#9429)
  Bump jackson-datatype-jsr310 from 2.14.0 to 2.14.1 (#9430)
  Bump lucene-highlighter from 9.4.1 to 9.4.2 (#9431)
  Fix weird checkbox styling (#9425)
  New translations JabRef_en.properties (Italian) (#9424)
  New translations JabRef_en.properties (German) (#9418)
Siedlerchr added a commit that referenced this pull request Dec 5, 2022
* upstream/main:
  Bump slf4j-api from 2.0.4 to 2.0.5 (#9428)
  Bump archunit-junit5-api from 1.0.0 to 1.0.1 (#9429)
  Bump jackson-datatype-jsr310 from 2.14.0 to 2.14.1 (#9430)
  Bump lucene-highlighter from 9.4.1 to 9.4.2 (#9431)
  Fix weird checkbox styling (#9425)
  New translations JabRef_en.properties (Italian) (#9424)
  New translations JabRef_en.properties (German) (#9418)
Siedlerchr added a commit to MaryJml/jabref that referenced this pull request Dec 13, 2022
* upstream/main: (37 commits)
  Update database context in state manager after loading (JabRef#9450)
  Bump classgraph from 4.8.151 to 4.8.152 (JabRef#9448)
  Bump appleboy/ssh-action from 0.1.5 to 0.1.6 (JabRef#9443)
  Bump Pendect/action-rsyncer from 1.1.0 to 2.0.0 (JabRef#9444)
  Bump jackson-dataformat-yaml from 2.14.0 to 2.14.1 (JabRef#9445)
  Bump unirest-java from 3.14.0 to 3.14.1 (JabRef#9447)
  Bump postgresql from 42.5.0 to 42.5.1 (JabRef#9446)
  New Crowdin updates (JabRef#9435)
  Return absolute path in case an absolute one is given (JabRef#9433)
  New Crowdin updates (JabRef#9434)
  Fix for issue: right click menu 6601 (JabRef#9271)
  Fix modernizer and refactor protected terms (JabRef#9427)
  Observable Preferences (OpenOffice) (JabRef#9422)
  Allow users to review backup changes before restoring them or merge them selectively (JabRef#9311)
  Bump slf4j-api from 2.0.4 to 2.0.5 (JabRef#9428)
  Bump archunit-junit5-api from 1.0.0 to 1.0.1 (JabRef#9429)
  Bump jackson-datatype-jsr310 from 2.14.0 to 2.14.1 (JabRef#9430)
  Bump lucene-highlighter from 9.4.1 to 9.4.2 (JabRef#9431)
  Fix weird checkbox styling (JabRef#9425)
  New translations JabRef_en.properties (Italian) (JabRef#9424)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants