Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no context menu with sorting on all entries group #9497

Merged
merged 1 commit into from
Dec 25, 2022
Merged

Fix no context menu with sorting on all entries group #9497

merged 1 commit into from
Dec 25, 2022

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Dec 24, 2022 •
edited
Loading

Regression that was introduced in #9286
https://discourse.jabref.org/t/how-sort-groups-a-z-not-subgroups/3682

grafik

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 24, 2022
@Siedlerchr Siedlerchr mentioned this pull request Dec 24, 2022
Merged
6 tasks
@calixtus calixtus merged commit 1d189fb into main Dec 25, 2022
@calixtus calixtus deleted the fixGroupAllEntriesContext branch December 25, 2022 20:01
Siedlerchr added a commit that referenced this pull request Dec 26, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into afterburner
04269e6 
* upstream/main:
  Bump classgraph from 4.8.152 to 4.8.153 (#9502)
  Bump slf4j-api from 2.0.5 to 2.0.6 (#9501)
  Bump org.beryx.jlink from 2.25.0 to 2.26.0 (#9500)
  Bump lucene-queries from 9.4.1 to 9.4.2 (#9499)
  Add double click on preview style to add/remove from the selected list (#9498)
  Fix no context menu with sorting on all entries group (#9497)
  Observable Preferences S (LastExportPath and Cleanups in JabRefPreferences and Globals) (#9493)
Siedlerchr added a commit that referenced this pull request Dec 27, 2022
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into fix-issue-#6448
7a3a57f 
* upstream/main:
  Bump classgraph from 4.8.152 to 4.8.153 (#9502)
  Bump slf4j-api from 2.0.5 to 2.0.6 (#9501)
  Bump org.beryx.jlink from 2.25.0 to 2.26.0 (#9500)
  Bump lucene-queries from 9.4.1 to 9.4.2 (#9499)
  Add double click on preview style to add/remove from the selected list (#9498)
  Fix no context menu with sorting on all entries group (#9497)
@HoussemNasri HoussemNasri mentioned this pull request Jan 4, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siedlerchr @calixtus