Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Set instead of List for custom journal abbreviations #9515

Merged
merged 10 commits into from
Jan 4, 2023
Merged

Use Set instead of List for custom journal abbreviations #9515

merged 10 commits into from
Jan 4, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Jan 2, 2023

Fixes #8928

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

koppor and others added 6 commits January 2, 2023 22:38
@koppor @Siedlerchr
@calixtus @ThiloteE
Use Set instead of List for custom journal abbreviations
9c2f360 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: ThiloteE <73715071+ThiloteE@users.noreply.github.com>
@koppor @Siedlerchr
Try to fix tests
3644d7e 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@koppor
Prepare parallel test execution
e42dd26
@koppor
Refine tests
6c9084c 
- Sort test cases
- More clear file names
- enable concurrency
- introduce "containsDuplicate"
- introduce "abbreviationToContain"
@koppor
More OO in JournalAbstractionsTabViewModel
5493e7a
@koppor
Switch from HashSet to List, refactor test
d8dc0e4
github-actions[bot]
github-actions bot reviewed Jan 3, 2023
View reviewed changes
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
src/test/java/org/jabref/gui/preferences/journals/JournalAbbreviationsViewModelTabTest.java Outdated Show resolved Hide resolved
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jan 3, 2023
calixtus
calixtus previously approved these changes Jan 3, 2023
View reviewed changes
@koppor koppor added this to the v5.9 milestone Jan 4, 2023
@koppor koppor merged commit 06771c8 into main Jan 4, 2023
@koppor koppor deleted the fix-8928 branch January 4, 2023 14:03
Siedlerchr added a commit to NiD133/jabref that referenced this pull request Jan 4, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into get_full_text
5448d36 
* upstream/main: (29 commits)
  Use Set instead of List for custom journal abbreviations (JabRef#9515)
  Delete snap.yml (JabRef#9526)
  New Crowdin updates (JabRef#9523)
  Fix not on fx thread error when downloading file (JabRef#9522)
  Fix downloading in case of circular redirect (JabRef#9519)
  Typo: sucess -> success (JabRef#9520)
  New Crowdin updates (JabRef#9517)
  Add CHANGELOG.md entry for 9472
  Fix journal abbbrev checker for curly braces (JabRef#9504)
  Remove journal_abbreviations_ieee_strings.csv from journal lists (JabRef#9511)
  Bump mockito-core from 4.10.0 to 4.11.0 (JabRef#9513)
  Bump lucene-core from 9.4.1 to 9.4.2 (JabRef#9512)
  Bump checkstyle from 10.5.0 to 10.6.0 (JabRef#9514)
  Create a better solution for define multi line fields (JabRef#9456)
  Check links once a month
  Really ignore CHANGELOG.md in link check
  Fix spaces
  Add missing dots
  Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2
  try to repack deb file (JabRef#9506)
  ...

# Conflicts:
#	CHANGELOG.md
#	src/main/java/org/jabref/gui/fieldeditors/LinkedFilesEditorViewModel.java
Siedlerchr added a commit to JabRef/jabref-koppor that referenced this pull request Jan 5, 2023
@Siedlerchr
Merge remote-tracking branch 'upstream/main' into restapi
4638d77 
* upstream/main: (244 commits)
  Use Set instead of List for custom journal abbreviations (JabRef#9515)
  Delete snap.yml (JabRef#9526)
  New Crowdin updates (JabRef#9523)
  Fix not on fx thread error when downloading file (JabRef#9522)
  Fix downloading in case of circular redirect (JabRef#9519)
  Typo: sucess -> success (JabRef#9520)
  New Crowdin updates (JabRef#9517)
  Add CHANGELOG.md entry for 9472
  Fix journal abbbrev checker for curly braces (JabRef#9504)
  Remove journal_abbreviations_ieee_strings.csv from journal lists (JabRef#9511)
  Bump mockito-core from 4.10.0 to 4.11.0 (JabRef#9513)
  Bump lucene-core from 9.4.1 to 9.4.2 (JabRef#9512)
  Bump checkstyle from 10.5.0 to 10.6.0 (JabRef#9514)
  Create a better solution for define multi line fields (JabRef#9456)
  Check links once a month
  Really ignore CHANGELOG.md in link check
  Fix spaces
  Add missing dots
  Squashed 'buildres/csl/csl-styles/' changes from 84dba23..43566f2
  try to repack deb file (JabRef#9506)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@calixtus calixtus calixtus left review comments

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
v5.9
Development

Successfully merging this pull request may close these issues.

Improve performance of journal abbreviation loading
3 participants
@koppor @Siedlerchr @calixtus