Changed the color of light-color-text and highlighted text in …

[Asrk03]

…entry merge dialogue

Fixes #9192

Before:

After:

• Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
• Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

[Siedlerchr]

Thanks for your work, I am not that happy with the chosen colors.
I think maybe something similar to the search color? Maybe you can also check some contras colors https://coolors.co/contrast-checker/

Search highlight color:

[Asrk03]

@Siedlerchr thank you for your response, will work on changes now.

[Siedlerchr]

Thanks for the updated colors! Looks better now for me. Let's ask the others. @JabRef/developers

[ThiloteE]

I think light yellow and light orange do not contrast with each other greatly, but oh well. Definitely better than before! I personally find it easier to read now. Thanks! I am in favour of merging this PR, unless somebody comes up with an even better solution.

With this PR:

[k3KAW8Pnf7mkmdSMPHz27]

• I like the change of text color to black

If we are interested in a discussion, I liked the dull red/sky blue for delete/add, but perhaps a higher contrast blue, maybe #006dff 😛

Anyway, I agree that this is a clear improvement

[k3KAW8Pnf7mkmdSMPHz27]

Just for clarity, I am in favor of merging the PR and perhaps discuss further during the dev-call?

[ThiloteE]

How about these three colours?

• #ADD, #AADDDD, or rgb(170,221,221)
• #FEC, #FFEECC, or rgb(255,238,204)
• #F99, #FF9999, or rgb(255,153,153)

Source: https://en.wikipedia.org/wiki/File:Safe_Chart_Colors-F99-FEC-ADD.jpg

Was taken from the wikipedia entry about colour blindness.
https://en.wikipedia.org/wiki/Color_blindness

[Asrk03]

Thank you for your suggestions!
Please let me know which one you like. I will make respective changes.
Personally I like 2nd better here.

[Siedlerchr]

I would be happy with 2 or 3

[calixtus]

How about the red from 4 with the orange from 3?

[Asrk03]

@calixtus I think this combo is not very pleasing to eyes

[Asrk03]

I think in this image the texts are discernable and the colors contrast well with each other too.
Should I finalize these colors?

[Siedlerchr]

@Asrk03
I agree, I would go for the last version here: #9546 (comment)

So I would suppose we decide now on that version

[Asrk03]

I have made the changes please review them @Siedlerchr @k3KAW8Pnf7mkmdSMPHz27 @ThiloteE @calixtus

[Siedlerchr]

Thanks again for your contributions and the updates!

[claell]

Sorry, I am late. Right now, it seems that the meaning of the colors are no longer there. At least in git, it is common to use red for deletions and green for additions (and neutral if nothing changed). I feel it is sensible to preserve that scheme, no? I can also open a new issue for that in case this is preferred.

[claell]

From Visual Studio Code (https://code.visualstudio.com/docs/sourcecontrol/overview):

[ThiloteE]

The red green combo is particular problematic for people with colour blindness.

[claell]

Yes, I saw that afterward. The thing is that the colors are used here to show information. So it might be hard to keep track of the changes when they are not red or green, I think. But I haven't tested, probably one can get used to that. I need to test that before making further statements on that.

When I upload the screenshot from VS Code to a color blindness simulator, the shades can still be differentiated; although not as much as the ones right now.

[ThiloteE]

@the-dino-girl, since you are very enthusiastic about JabRef themes, I wanted to make you aware of these issues here. Just so you know. Maybe you find some great looking combination that is both pleasing to the eyes, conservative and close enough to the red / green combination that is traditionally used by github and other programms to denote removal and addition of code and also does not exclude people with colour blindness.

[claell]

@ThiloteE the user reference above isn't working. Has the user left GitHub or is there some spelling mistake?

[ThiloteE]

Yes, she has deleted her account.

[koppor]

I can also open a new issue for that in case this is preferred.

@claell Yes, please do. Please try to collect the information provided here in a structured form. Especially MADR could be of help here. Feel free to open a pull request with the different options (and links of them). Then we can decide and then move forward to an implementation.

Reasoning: For a quick reader, it is very hard to follow the discussion here and to be able to decide something. Is it just about changing a color back to something or is it about a general UI design of JabRef? - Refs #7771.