-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a min width and a min height for the main window #9608
Conversation
Hello @waterflow80 , thanks for your interest in JabRef and open source programming. Can you provide some more information on your changes please? What is your motivation for your change, is there an issue related to your changes, why would be a minimum height oder width necessary, why exactly 330 px? Thanks! |
Also please note that the checklist is mandatory. |
@calixtus Thank you for your feedback. I think having the app's window resized until it's no longer seen is not a good thing, as it's shown in the I also specified the reasons why I've chosen the values of the |
@@ -68,6 +68,11 @@ private void openWindow(Stage mainStage) { | |||
mainFrame.init(); | |||
|
|||
GuiPreferences guiPreferences = preferencesService.getGuiPreferences(); | |||
|
|||
// Set the min-width and min-height for the main window |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think the comment is necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HoussemNasri Thank you for your feedback, I'll remove it if necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in DevCall. It is OK. More comments are in the issue.
PR Description
Fixes #9606
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)