Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a min width and a min height for the main window #9608

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

waterflow80
Copy link
Contributor

@waterflow80 waterflow80 commented Feb 8, 2023

PR Description

Fixes #9606

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus
Copy link
Member

calixtus commented Feb 8, 2023

Hello @waterflow80 , thanks for your interest in JabRef and open source programming. Can you provide some more information on your changes please? What is your motivation for your change, is there an issue related to your changes, why would be a minimum height oder width necessary, why exactly 330 px? Thanks!

@calixtus
Copy link
Member

calixtus commented Feb 8, 2023

Also please note that the checklist is mandatory.

@waterflow80
Copy link
Contributor Author

waterflow80 commented Feb 8, 2023

@calixtus Thank you for your feedback.

I think having the app's window resized until it's no longer seen is not a good thing, as it's shown in the
GIF image in the issue #9606 description. And almost every app has a minimum window size.

I also specified the reasons why I've chosen the values of the minHeight and the minWidth in the issue #9606 , although
these values can be discussed or reviewed.

@waterflow80 waterflow80 changed the title fx-for-9606. Adding a min width and a min height for the main window Adding a min width and a min height for the main window Feb 8, 2023
@@ -68,6 +68,11 @@ private void openWindow(Stage mainStage) {
mainFrame.init();

GuiPreferences guiPreferences = preferencesService.getGuiPreferences();

// Set the min-width and min-height for the main window
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the comment is necessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HoussemNasri Thank you for your feedback, I'll remove it if necessary.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed in DevCall. It is OK. More comments are in the issue.

@koppor koppor merged commit 644e00e into JabRef:main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set a minHeight and a minWidth for the main window
4 participants