-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default hierarchical context in group creation #9636
Conversation
Thank you for working on this. You're definitely going on the right track. However, I believe it would be great if I can do this without having to open the "JabRef Preferences" dialog. One option that comes to mind is to set the "Hierarchical context" to the option selected in the last session. In other words, if the user selected "Intersection," then closed and reopened the "Add Group" dialog, "Intersection" should be still selected. You can keep most of the code you have written so far. The changes to |
Thanks for your feedback @HoussemNasri. I've updated the PR with the requested changes - the |
CHANGELOG.md
Outdated
@@ -12,6 +12,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve | |||
### Added | |||
|
|||
- We added a field showing the BibTeX/biblatex source for added and deleted entries in the "External Changes Resolver" dialog. [#9509](https://github.com/JabRef/jabref/issues/9509) | |||
- We added an option in Groups Preferences to set the default hierarchical context used when creating a new group [#9141](https://github.com/JabRef/jabref/issues/9141) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the changelog entry? And maybe put it under Changed instead of Added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much! +1 also for adding the test cases!
Looking forward towards more contributions :)
Thanks, happy to help! |
This fixes #9141 by persisting the most recently used hierarchical context within
GroupPreferences
. This saved context is used when opening theAdd Group
dialog the next time.CHANGELOG.md
described in a way that is understandable for the average user (if applicable)