-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 9646: Right-click context menu "Attach file from URL" #9648
Conversation
I had to duplicate some code from The one thing that AttachFileAction has and AttachFileFromURLAction doesn't is the undo() functionality. I was unsure how to implement it as in LinkedFilesEditorViewModel I couldn't find any |
god eclipse is so bad |
Can you please fix the checkstyle for me. I can't seem to get it to work in Eclipse. Eclipse is so shitty it hurts me. |
@bf Yes, Eclipse (although I use it myself) is not really compatible with the style we use in intellij (all others use intellij) |
thank you so much! |
Regarding undo, you can ignore this for now. That's still an issue on our list to provide a better solution. |
Thanks for the kind refactor @Siedlerchr. I've been working with the most recent version since a few hours and it works well. Only thing I noticed is that some downloads return a 403 (I think it was sciencedirect.com) because the website is protected by cloudflare. But the download is also failing via curl (chrome dev tools -> copy request as curl) due to lack of Cloudflare cookies. So I think this is an unrelated issue because it also happens with the existing "download from url" feature. Also it is out of scope for JabRef to circumvent CloudFlare protections. Again, thanks for the kind collaborative environment on this project and your super-quick turnaround times. Really appreciate it. |
Hi bf, I took the liberty to refactor your very neat PR just a little bit. I hope you don't mind. I just moved the method from the utility class as a static method to your new attach command. |
Many thanks again for your contribution! Looking forward for more ;) |
…rg.mariadb.jdbc-mariadb-java-client-3.1.0 * upstream/main: (357 commits) Fix syntax Add experimental Fetcher for Bibliotheksverbund Bayern with MarcXML parser (#9641) Update guidelines-for-setting-up-a-local-workspace.md Update guidelines-for-setting-up-a-local-workspace.md Bump org.tinylog:slf4j-tinylog from 2.6.0 to 2.6.1 (#9665) Bump apple-actions/import-codesign-certs from 1 to 2 (#9662) Bump com.puppycrawl.tools:checkstyle from 10.8.0 to 10.8.1 (#9661) Bump gittools/actions from 0.9.15 to 0.10.2 (#9663) Bump hmarr/auto-approve-action from 3.1.0 to 3.2.0 (#9664) Bump io.github.classgraph:classgraph from 4.8.156 to 4.8.157 (#9666) Bump org.tinylog:tinylog-api from 2.6.0 to 2.6.1 (#9667) Add option to open arks in the browser from an ark identifier (#9601) remove "jdk 19 does not work" (#9658) Fulltext fetcher for IACR eprints (#9651) Observable Preferences S (#9619) Issue 9646: Right-click context menu "Attach file from URL" (#9648) Improve the INSPIREFetcher in "Update with bibliographic information from the web" (#9645) Bump appleboy/ssh-action from 0.1.7 to 0.1.8 (#9653) Bump com.fasterxml.jackson.datatype:jackson-datatype-jsr310 (#9656) Bump com.puppycrawl.tools:checkstyle from 10.7.0 to 10.8.0 (#9655) ...
Fixes #9646
Add "Attach file from URL" to right-click context menu. Same functionality as the "download file" from the detail dialog.
right-click context menu:
url dialog:
file added:
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)