Add BibLatex date formats for parsing to Date.java #9720

GuyPuts · 2023-03-31T16:02:57Z

contributes to #2753

Adds date formats set by BibLatex to the Date.java class. Formats are included in the list that was already present in the class. Tested locally.

Compulsory checks

Give feedback

Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.
Options

Adds date formats set by BibLatex to the Date.java class. Formats are included in the list that was already present in the class. Tested locally.

Siedlerchr · 2023-03-31T16:38:43Z

Thanks for your contribution. Please link to the issue with e.g Fixes #.... and also please add tests and a changelog entry

calixtus

Please add a changelog entry and most importantly add tests. Thanks!

calixtus · 2023-03-31T21:46:10Z

src/main/java/org/jabref/model/entry/Date.java

+                "y-M/y-M",                              // covers 2015-01/2015-02
+                "MMMM y/MMMM y",                        // covers January 2015/February 2015
+                "d MMMM y/d MMMM y",                    // covers 20 January 2015/20 February 2015
+                "y G",                                  // covers 1 BC
+                "y G / y G",                            // covers 30 BC / 5 AD
+                "yyyy G / yyyy G",                      // covers 0030 BC / 0005 AD
+                "yyyy-MM G / yyyy-MM G",                // covers 0030-01 BC / 0005-02 AD


These date ranges are not yet parsed correctly. The static parse method must probably be adapted somehow.

Yes, see https://docs.oracle.com/en/java/javase/19/docs/api/java.base/java/time/format/DateTimeFormatter.html
and

jabref/src/main/java/org/jabref/model/entry/Date.java

Lines 102 to 103 in 170033a

// if dateString has format of uuuu/uuuu, treat as date range

if (dateString.matches("[0-9]{4}/[0-9]{4}")) {

There are already existing unit tests which you need to extend.

GuyPuts · 2023-04-22T13:16:51Z

PR was updated

koppor · 2023-04-29T00:25:16Z

@GuyPuts After pushing, you should check the output of the tests going on at GitHub. I put you a screenshot:

It says, checkstyle failed. You can go to the files tab to see the errors https://github.com/JabRef/jabref/pull/9720/files

Alternateively, you can execute checkstyle in your ide as described at https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-13-code-style.html

src/test/java/org/jabref/model/entry/DateTest.java

koppor

I think besides the small comments, this is good to go?

CHANGELOG.md

src/main/java/org/jabref/model/entry/Date.java

…biblatex-date-formats * upstream/main: (132 commits) Add four rules not having any effect Apply BooleanChecksNotInverted Remove unused RadioButtonCell Minimal config for openRewrite Fix missing # Fix modernizer (JabRef#9824) CHANGELOG.md Removed unused code Refined ui Dissolved FileTab and moved contents to EntryTab Renamed CustomEditorFieldsTab to EntryEditorTabsTab Fixed antipattern, fixed radiobutton with checkbox Renamed ImportExportPreferences to ExportPreferences Improve search history by attaching change listener (JabRef#9794) Separated WebSearchPrefs and ExportPrefs Separated WebSearchTab and ExportTab Renamed ImportExportTab to WebSearchTab Fix split multiline localization (JabRef#9814) New Crowdin updates (JabRef#9834) change versin to 0.8.10 ...

make parameterized test

koppor · 2023-05-07T11:59:06Z

DateCheckerTest complains about failing tests

koppor

Since the tests fail, something should be done to get them running.

rather add a todo

Siedlerchr · 2023-05-07T13:08:29Z

Follow up task (n oted in the issue)
/* TODO: The following date formats do not yet work and need to be created with tests
* "u G", // covers 1 BC
* "u G / u G", // covers 30 BC / 5 AD
* "uuuu G / uuuu G", // covers 0030 BC / 0005 AD
* "uuuu-MM G / uuuu-MM G", // covers 0030-01 BC / 0005-02 AD
* "u'-'", // covers 2015-
* "u'?'", // covers 2023?
*/

Add BibLatex date formats for parsing to Date.java

ff1e8bd

Adds date formats set by BibLatex to the Date.java class. Formats are included in the list that was already present in the class. Tested locally.

calixtus requested changes Mar 31, 2023

View reviewed changes

ThiloteE added the bib(la)tex label Apr 1, 2023

Siedlerchr added the status: changes required Pull requests that are not yet complete label Apr 1, 2023

PFvanBeerendonk and others added 3 commits April 14, 2023 23:37

dateRanges

3a93e97

Add BibLatex date formats regex

881b76d

Merge branch 'main' into issue-2573-support-biblatex-date-formats

0071d80

koppor reviewed Apr 29, 2023

View reviewed changes

src/test/java/org/jabref/model/entry/DateTest.java Outdated Show resolved Hide resolved

koppor requested changes Apr 29, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

koppor reviewed Apr 29, 2023

View reviewed changes

src/main/java/org/jabref/model/entry/Date.java Outdated Show resolved Hide resolved

Siedlerchr added 2 commits May 6, 2023 19:21

Prefer u over y, remove some patterns that have not a test yet

ed0915a

make parameterized test

Siedlerchr added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed status: changes required Pull requests that are not yet complete labels May 6, 2023

Siedlerchr added 2 commits May 6, 2023 20:49

checkstyle

198979d

checkstyle

81418d6

koppor requested changes May 7, 2023

View reviewed changes

Siedlerchr removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 7, 2023

remove extra hack

16e1b51

rather add a todo

Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 7, 2023

koppor approved these changes May 7, 2023

View reviewed changes

Siedlerchr merged commit 44564ad into JabRef:main May 7, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add BibLatex date formats for parsing to Date.java #9720

Add BibLatex date formats for parsing to Date.java #9720

GuyPuts commented Mar 31, 2023 •

edited by ThiloteE

Loading

Compulsory checks

Siedlerchr commented Mar 31, 2023

calixtus left a comment

calixtus Mar 31, 2023

Siedlerchr Apr 15, 2023

GuyPuts commented Apr 22, 2023

koppor commented Apr 29, 2023 •

edited

Loading

koppor left a comment

koppor commented May 7, 2023

koppor left a comment

Siedlerchr commented May 7, 2023

	// if dateString has format of uuuu/uuuu, treat as date range
	if (dateString.matches("[0-9]{4}/[0-9]{4}")) {

Add BibLatex date formats for parsing to Date.java #9720

Add BibLatex date formats for parsing to Date.java #9720

Conversation

GuyPuts commented Mar 31, 2023 • edited by ThiloteE Loading

Compulsory checks

Siedlerchr commented Mar 31, 2023

calixtus left a comment

Choose a reason for hiding this comment

calixtus Mar 31, 2023

Choose a reason for hiding this comment

Siedlerchr Apr 15, 2023

Choose a reason for hiding this comment

GuyPuts commented Apr 22, 2023

koppor commented Apr 29, 2023 • edited Loading

koppor left a comment

Choose a reason for hiding this comment

koppor commented May 7, 2023

koppor left a comment

Choose a reason for hiding this comment

Siedlerchr commented May 7, 2023

GuyPuts commented Mar 31, 2023 •

edited by ThiloteE

Loading

koppor commented Apr 29, 2023 •

edited

Loading