Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support for Markdown syntax for strikethrough and task lists #9726

Merged
merged 4 commits into from
Apr 2, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Apr 1, 2023

To reduce the number of dependencies (due to JDK-8240567; refs #5226), I removed two dependencies IMHO used very seldom.

In the current JabRef, if you select the build-in preview, you get a markdown rendering. This changes now a bit.

Before:

image

After:

image

Compulsory checks

Preview Give feedback

@koppor koppor added the dependencies Pull requests that update a dependency file label Apr 1, 2023
@Siedlerchr
Copy link
Member

I don't think that helps a lot

calixtus
calixtus previously approved these changes Apr 1, 2023
@koppor
Copy link
Member Author

koppor commented Apr 2, 2023

Since the task list is broken nevertheless (see screenshot), I go ahead with merge.

@koppor koppor merged commit 1896c99 into main Apr 2, 2023
@koppor koppor deleted the remove-markdown-extra-plugins branch April 2, 2023 23:13
@koppor koppor restored the remove-markdown-extra-plugins branch April 6, 2023 08:25
@koppor koppor deleted the remove-markdown-extra-plugins branch April 6, 2023 08:25
Siedlerchr added a commit to ssrpro/jabref that referenced this pull request Apr 9, 2023
…fix-for-issue-9362-2

* 'fix-for-issue-9362-2' of github.com:ssrpro/jabref: (39 commits)
  Update CHANGELOG.md
  Move location of the pin button of the global search dialog to the top
  Remove support for Markdown syntax for strikethrough and task lists (JabRef#9726)
  Fix dots in changelog
  Fix CitationStyleTest#testDefaultCitation test
  Save configuration regardless of the action performed (cancel included)
  Refactor ThreeWayMergeToolbar
  Refactor
  Fix typo
  Save three way merge view toolbar preferences in duplicateslverdialog
  Store preference as boolean instead of enum
  Update citeproc to beta (JabRef#9721)
  Add links in JavaDoc
  Convert BibField from class to record
  Squashed 'buildres/csl/csl-locales/' changes from 47edde1be3..a7c6f63e25
  Refresh example styles
  Squashed 'buildres/csl/csl-styles/' changes from ca943b70d7..41531558a8
  Global Search UI preview is dark in dark theme when no entry is shown (JabRef#9718)
  resolved changelog for pr9716
  updated changelog for pr9716
  ...

# Conflicts:
#	CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants