Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added scrolling in GroupsPanel when dragging a group #9728

Merged
merged 8 commits into from
Apr 4, 2023

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Apr 2, 2023

Fixes #2869
A present for @AEgit, one of our most loyal users.
Also refactored GroupsTreeView a bit.

Compulsory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@calixtus calixtus added ui type: code-quality Issues related to code or architecture decisions groups status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Apr 2, 2023
@AEgit
Copy link

AEgit commented Apr 4, 2023

Cheers, once this pull request is merged with the main dev version, I will try the new functionality!

@Siedlerchr
Copy link
Member

No risk no fun!

@Siedlerchr Siedlerchr merged commit e9a0bf5 into main Apr 4, 2023
@Siedlerchr Siedlerchr deleted the groups_panel_scroll branch April 4, 2023 17:35
@AEgit
Copy link

AEgit commented Apr 5, 2023

Well done, the originally reported issue appears to be fixed with this commit! There are some quirks I noticed, that may or may not be related to the fix - I report them here: #2869 (comment)

credmond added a commit to credmond/jabref that referenced this pull request Jul 24, 2023
…nt: JabRef#8785. Now, once again, the mouse click is handled and consumed at the capture stage if the expansion pane is licked, therefore preventing the node from being selected.
credmond added a commit to credmond/jabref that referenced this pull request Jul 24, 2023
…nt: JabRef#8785. Now, once again, the mouse click is handled and consumed at the capture stage if the expansion pane is licked, therefore preventing the node from being selected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
groups status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers type: code-quality Issues related to code or architecture decisions ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups panel does not scroll when group is assigned to another group as subgroup
3 participants