Current library's bib file is removed from the unlinked file search results

CHANGELOG.md

@@ -57,6 +57,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We fixed the double paste issue when <kbd>Cmd</kbd> + <kbd>v</kbd> is pressed on 'New entry from plaintext' dialog. [#9367](https://github.com/JabRef/jabref/issues/9367)
 - We fixed an issue where the pin button on the Global Search dialog was located at the bottom and not at the top. [#9362](https://github.com/JabRef/jabref/issues/9362)
 - We fixed the log text color in the event log console when using dark mode. [#9732](https://github.com/JabRef/jabref/issues/9732)
+- We fixed an issue where searching for unlinked files would include the current library's .bib file [#9735](https://github.com/JabRef/jabref/issues/9735)
 
 ### Removed
 

src/main/java/org/jabref/gui/externalfiles/UnlinkedPDFFileFilter.java

@@ -35,7 +35,7 @@ public boolean accept(Path pathname) throws IOException {
         if (Files.isDirectory(pathname)) {
             return true;
         } else {
-            return fileFilter.accept(pathname) && !lookup.lookupDatabase(pathname);
+            return fileFilter.accept(pathname) && !lookup.lookupDatabase(pathname) && !lookup.getPathOfDatabase().equals(pathname);
         }
     }
 }

src/main/java/org/jabref/logic/util/io/DatabaseFileLookup.java

@@ -26,6 +26,8 @@ public class DatabaseFileLookup {
 
     private final List<Path> possibleFilePaths;
 
+    private final Path pathOfDatabase;
+
     /**
      * Creates an instance by passing a {@link BibDatabase} which will be used for the searches.
      */
@@ -37,6 +39,7 @@ public DatabaseFileLookup(BibDatabaseContext databaseContext, FilePreferences fi
         for (BibEntry entry : databaseContext.getDatabase().getEntries()) {
             fileCache.addAll(parseFileField(entry));
         }
+        this.pathOfDatabase = databaseContext.getDatabasePath().orElse(Path.of(""));
     }
 
     /**
@@ -66,4 +69,11 @@ private List<Path> parseFileField(BibEntry entry) {
                     .map(Optional::get)
                     .collect(Collectors.toList());
     }
+
+    /**
+     * @return "" if the path does not exist
+     */
+    public Path getPathOfDatabase() {
+        return pathOfDatabase;
+    }
 }

src/test/java/org/jabref/gui/externalfiles/UnlinkedFilesCrawlerTest.java

@@ -1,15 +1,19 @@
 package org.jabref.gui.externalfiles;
 
+import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.stream.Stream;
 
 import org.jabref.gui.util.FileNodeViewModel;
+import org.jabref.logic.util.StandardFileType;
 import org.jabref.model.database.BibDatabaseContext;
 import org.jabref.preferences.FilePreferences;
 
 import org.junit.jupiter.api.Test;
 import org.junit.jupiter.api.io.TempDir;
 
+import static java.nio.file.DirectoryStream.Filter;
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.mockito.ArgumentMatchers.any;
 import static org.mockito.Mockito.mock;
@@ -35,4 +39,29 @@ public void minimalGitIgnore(@TempDir Path testRoot) throws Exception {
 
         assertEquals(new FileNodeViewModel(testRoot), fileNodeViewModel);
     }
+
+    @Test
+    public void excludingTheCurrentLibraryTest(@TempDir Path testRoot) throws IOException {
+        // Adding 3 files one of which is the database file
+        Files.createFile(testRoot.resolve("unlinkedPdf.pdf"));
+        Files.createFile(testRoot.resolve("another-unlinkedPdf.pdf"));
+        Path databasePath = testRoot.resolve("test.bib");
+        Files.createFile(databasePath);
+
+        BibDatabaseContext databaseContext = new BibDatabaseContext();
+        databaseContext.setDatabasePath(databasePath);
+
+        FilePreferences filePreferences = mock(FilePreferences.class);
+        Filter<Path> fileExtensionFilter = new FileExtensionViewModel(StandardFileType.ANY_FILE, filePreferences).dirFilter();
+        UnlinkedPDFFileFilter unlinkedPdfFileFilter = new UnlinkedPDFFileFilter(fileExtensionFilter, databaseContext, filePreferences);
+
+        UnlinkedFilesCrawler unlinkedFilesCrawler = new UnlinkedFilesCrawler(testRoot, unlinkedPdfFileFilter, DateRange.ALL_TIME, ExternalFileSorter.DEFAULT, databaseContext, filePreferences);
+        FileNodeViewModel fileNodeViewModel = unlinkedFilesCrawler.searchDirectory(testRoot, unlinkedPdfFileFilter);
+
+        // checking to see if the database file has been filtered
+        try (Stream<Path> filesInitially = Files.list(testRoot)) {
+            int count = (int) filesInitially.count();
+            assertEquals(fileNodeViewModel.getFileCount(), count - 1);
+        }
+    }
 }