Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved ContentSelectorsDialog to library properties and preferences to file menu #9768

Merged
merged 7 commits into from
Apr 18, 2023
Merged

Moved ContentSelectorsDialog to library properties and preferences to file menu #9768

merged 7 commits into from
Apr 18, 2023

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Apr 16, 2023 •
edited
Loading

and move removed options menu

grafik

grafik

Doc PR is JabRef/user-documentation#451

Compulsory checks
Preview Give feedback

@calixtus calixtus added ui status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers preferences labels Apr 16, 2023
calixtus added a commit to JabRef/user-documentation that referenced this pull request Apr 16, 2023
@calixtus
Changed menu title (depends on JabRef/jabref#9768)
23c07d9
@Siedlerchr
Copy link
Member

seems like some view model unit test fails

@calixtus
Copy link
Member Author

Forgot to call setValues() in the test suite.

@koppor
Copy link
Member

koppor commented Apr 17, 2023

Current user documentation at https://docs.jabref.org/advanced/contentselector

@koppor
Copy link
Member

koppor commented Apr 17, 2023

Before:

image

koppor
koppor previously approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not now that this was a library-specific setting. Thank you for making the UI constent!

(This somehow refs #8701)

CHANGELOG.md Outdated Show resolved Hide resolved
@calixtus @koppor
Update CHANGELOG.md
23b7394 
Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>
@Siedlerchr Siedlerchr merged commit dab8516 into main Apr 18, 2023
@Siedlerchr Siedlerchr deleted the move-contentselectors branch April 18, 2023 17:04
@Siedlerchr Siedlerchr mentioned this pull request Sep 2, 2023
Closed
2 tasks
Siedlerchr added a commit to JabRef/user-documentation that referenced this pull request Sep 3, 2023
@calixtus @Siedlerchr
Changed options menu title (depends on JabRef/jabref#9768) (#451)
2d1babd 
* Changed menu title (depends on JabRef/jabref#9768)

* Update protectedterms.md

* Update customkeybindings.md

* Update filelinks.md

* Update customentrytypes.md

* Update groups.md

* Update groups.md

* Update timestamp.md

* Update README.md

* Update README.md

* Update customexports.md

* Update README.md

* Update specialfields.md

* Update keywords.md

* Update citationkeypatterns.md

* Update import-using-online-bibliographic-database.md

---------

Co-authored-by: Christoph <cschwentker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
preferences status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@calixtus @Siedlerchr @koppor