Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable single backslashes at fileDirectory #9889

Merged
merged 9 commits into from
May 15, 2023
Merged

Conversation

koppor
Copy link
Member

@koppor koppor commented May 14, 2023

My JabRef showed C:git-repositoriesjabrefsrctestresourcespdfs as path. Don't know why. I checked the source and modified the parsing logic that JabRef also accepts paths with single \ in the field.

@Comment{jabref-meta: fileDirectory:C:\git-repositories\jabref\src\test\resources\pdfs;}

When JabRef writes, there will be double backslashes.

This PR also modifes the meta data writing code in a way that the trailing ; of each entry could be removed. I think, this should be done for JabRef 6.0. -- Maybe, also a complete rewrite of the metadata serialization could be done (refs JabRef#232)

Minor fixes include

  • Rename variable to lower case start
  • Use .withField in test

Compulsory checks

Preview Give feedback

@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 15, 2023
@Siedlerchr
Copy link
Member

can you add a test case for unc path?

@github-actions
Copy link
Contributor

Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues.

More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html.

@calixtus calixtus merged commit 4f78ecb into main May 15, 2023
@calixtus calixtus deleted the backslashes-are-ok branch May 15, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants