Fix UTF bom parsing #9927
Merged
Fix UTF bom parsing #9927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9926
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/jabref/logic/importer/fileformat/BibtexImporter.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/importer/fileformat/BibtexImporter.java
Outdated
Show resolved
Hide resolved
|
Your code currently does not meet JabRef's code guidelines. The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR. Please carefully follow the setup guide for the codestyle. Afterwards, please run checkstyle locally and fix the issues. More information on code quality in JabRef is available at https://devdocs.jabref.org/getting-into-the-code/development-strategy.html. |
|
todo add bib with the header and the formatting also as test file |
split up in two methods
fix some markdown violations
…hEncoding * upstream/main: Add fill in of selectedApplicationProperty when opening the editDialog of external application preference (#9921) Fix empty fields being added to the entry table preferences (#9916) checkstyle Update tinylog.properties Fixed command name More error handling Fix IOUtils usage Add xdg-user-dirs call to Linux.java Fix formatting Check for existance Incorporate user feedback Fix tests Respect OS language at NativeDesktop#getDefaultFileChooserDirectory # Conflicts: # CHANGELOG.md
koppor
approved these changes
May 20, 2023
| - We fixed the Save/save as file type shows BIBTEX_DB instead of "Bibtex library". [#9372](https://github.com/JabRef/jabref/issues/9372) | ||
| - We fixed the default main file directory for non-English Linux users. [#8010](https://github.com/JabRef/jabref/issues/8010) | ||
| - We fixed an issue when overwriting the owner was disabled. [#9896](https://github.com/JabRef/jabref/pull/9896) |
There was a problem hiding this comment.
It was a merge thing. Somehow this was deleted in the main.
calixtus
approved these changes
May 20, 2023
|
Codewise looks good. so lets merge it. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
line.starts with fails on utf bom chars, because the % sign is actually at position 1 and not on pos 0 in the string.
java reads the bom chars as well.
Fixes #9926
Compulsory checks