-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update citationkeypatterns.md #312
Conversation
k3KAW8Pnf7mkmdSMPHz27
commented
Sep 25, 2020
- Removes dots after list items. Their use was inconsistent.
- Clarifications to the regex modifier, authIniN and edtrIniN.
- Adds a short section on using InternalField/StandardField/SpecialField/IEEEField.
* Removes dots after list items. Their use was inconsistent. * Clarifications to the regex modifier, authIniN and edtrIniN. * Adds a short section on using InternalField/StandardField/SpecialField/IEEEField.
I was thinking I'd make a sweep over the "special field markers" and "modifiers" and add/change/remove as needed aiming at closing #179, at least temporarily. I just cannot do it in one go. |
Thanks for taking on that issue. Tell us if we can help somehow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Changing "key pattern" to "field marker" will clarify the help. Great!
- Since this is all about citation key, when "key" is used, it may be changed to "citation key".
- Additionally, you may consider adding the example included in https://discourse.jabref.org/t/searching-within-years/1512/3
Hey @mlep ! I appreciate the feedback. Something analogous to having a help document exclusively for the bracketed expressions? |
Sorry for being unclear. I was thinking about adding the following case to the help file (a user noticed in was not in the help file, although it was useful): |
That example should probably be added in |
Oh yes, you are right. Please, discard my suggestion! |
|
@Siedlerchr great and thank you for the reference! I'll update the "How to configure section", |
Is there some way for me to make the previews of the "updated" screenshots on GitHub easier for reviewers? I have tried to follow the naming-scheme in the folder and left the old images alone. |
@k3KAW8Pnf7mkmdSMPHz27 Not sure what you mean. I always view the markdown file on GitHub. In this case: https://github.com/k3KAW8Pnf7mkmdSMPHz27/user-documentation/blob/patch-2/en/setup/citationkeypatterns.md Regarding the "naming-scheme", the numbers at the end of a file name ( You can replace the old screenshots. Otherwise, it gets hard for us (me ^^) to decide whether |
Ah, nice. Sorry about the confusion. I have been using the "rich diff" https://github.com/JabRef/user-documentation/pull/312/files?short_path=4b29b5e#diff-4b29b5ebf73395e336a4707100425449 and the new images does not load there.
Oups X) |
…into patch-2 � Conflicts: � en/setup/citationkeypatterns.md
@Siedlerchr thank you for bringing issue #7012 to my attention! Should it be a documented feature that the field markers perform a comparison ignoring case?
On an almost related note, I wanted to make a more advanced example, but I think I ended up with something that is too convoluted and I'd appreciate feedback.
|
How to set a citation key pattern for a single library
# Conflicts: # en/setup/citationkeypatterns.md
I don't think I have missed adding anything, so I am removing this from "draft". |
I think I might have been sitting long enough with this to tunnel vision a bit, comments (including of what should be removed) are most welcome, and probably needed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, haven't checked the screenshots, but a huge thanks for updating/correcting the docs regarding this! 🥇