Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Case: exemplify the menus #9339

Closed
mlep opened this issue Nov 2, 2022 · 4 comments · Fixed by #9382
Closed

Convert Case: exemplify the menus #9339

mlep opened this issue Nov 2, 2022 · 4 comments · Fixed by #9382
Assignees
@manv-afk
Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui

Comments

@mlep
Copy link
Contributor

mlep commented Nov 2, 2022

Is your suggestion for improvement related to a problem? Please describe.
Just trying to make the UI more practical.

Currently, the sub-menus of Change case looks like this:

ChangeCase

If you have no background in typography, the meanings are not obvious (Capitalize vs Upper case. Sentence case vs Title case)

Describe the solution you'd like
Alter the sub-menus into:

Capitalize
lower case
Sentence case
Title Case
UPPER CASE

And alter the tips (displayed when you stay long over the menu) accordingly. Example for Title Case:
Capitalize all words, but converts articles, prepositions, and conjunctions to lower case.
will become
Capitalize all Words, but Converts Articles, Prepositions, and Conjunctions to Lower Case.

Tip: change JabRef UI into French language to looks what it will look like (yeah, this is already implemented in French)
@Siedlerchr Siedlerchr added ui good first issue An issue intended for project-newcomers. Varies in difficulty. labels Nov 2, 2022
@Siedlerchr Siedlerchr moved this to Free to take in Good First Issues Nov 2, 2022
IanAllenWSU pushed a commit to roryoday/jabref that referenced this issue Nov 3, 2022
@IanAllen51
Modified LowerCaseFormatter, TitleCaseFormatter, and UpperCaseFormatt…
301a209 
…er.java to exemplify Change case sub-menu issue JabRef#9339
IanAllenWSU pushed a commit to roryoday/jabref that referenced this issue Nov 3, 2022
@IanAllen51
Modified CHANGELOG.md to include changes made for issue JabRef#9339
0eca31c
@alescrocaro alescrocaro mentioned this issue Nov 17, 2022
Closed
@koppor
Copy link
Member

koppor commented Nov 17, 2022

This is the screenshot for the menu location:

grafik

French:

grafik

@koppor koppor moved this from Free to take to Reserved in Good First Issues Nov 17, 2022
@koppor koppor moved this from Reserved to In Progress in Good First Issues Nov 17, 2022
manv-afk pushed a commit to manv-afk/jabref that referenced this issue Nov 18, 2022
We modified the Change case sub-menus and their corresponding tips (d…
c917db3 
…isplayed when you stay long over the menu) to properly reflect exemplified cases. [JabRef#9339](JabRef#9339)
@manv-afk manv-afk mentioned this issue Nov 18, 2022
Merged
5 tasks
@manv-afk
Copy link
Contributor

Hello, I've made a new PR for this issue, don't hesitate to give me some feedback if I need to change anything else for this issue.

@JVZavatin JVZavatin mentioned this issue Nov 21, 2022
Open
@michaela559
Copy link

hello is this fixed?

@manv-afk
Copy link
Contributor

Hello, I'm fixing it in this PR : #9382

Siedlerchr pushed a commit that referenced this issue Nov 30, 2022
@manv-afk
Exemplified menu entries for change case menu (#9382)
1e3bc02 
* We modified the Change case sub-menus and their corresponding tips (displayed when you stay long over the menu) to properly reflect exemplified cases. [#9339](#9339)

* Use l10n for menu entries string

* fix changelog codestyle issue

* fix test issue

Co-authored-by: manu-vaillant-afk <manu.vaillant@student.hers.be>
Repository owner moved this from In Progress to Done in Good First Issues Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manv-afk manv-afk

Labels
entry-editor good first issue An issue intended for project-newcomers. Varies in difficulty. ui
Projects
Good First Issues
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Exemplified menu entries for change case menu manv-afk/jabref
5 participants
@Siedlerchr @koppor @mlep @manv-afk @michaela559