-
-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize the generation of completion matches #136
Labels
Milestone
Comments
Jacalz
added
enhancement
New feature or request
performance
Improve application performance
labels
Jan 12, 2024
Jacalz
added a commit
that referenced
this issue
Jan 13, 2024
Jacalz
added a commit
that referenced
this issue
Jan 13, 2024
Jacalz
added a commit
that referenced
this issue
Jan 13, 2024
Performance improvement is improved an order of magnitude. |
Jacalz
added a commit
that referenced
this issue
Jan 24, 2024
Jacalz
added a commit
that referenced
this issue
Jan 24, 2024
Jacalz
added a commit
that referenced
this issue
Jan 24, 2024
Jacalz
added a commit
that referenced
this issue
Mar 18, 2024
Jacalz
added a commit
that referenced
this issue
Mar 18, 2024
Jacalz
added a commit
that referenced
this issue
Mar 18, 2024
Jacalz
added a commit
that referenced
this issue
Apr 12, 2024
Jacalz
added a commit
that referenced
this issue
Apr 12, 2024
Jacalz
added a commit
that referenced
this issue
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Checklist
Is your feature request related to a problem?
The code in https://github.com/Jacalz/rymdport/blob/main/internal/transport/completion.go is more or less a direct copy of the autocompletion generation found in Wormhole William. It has served us very well but it does allocate a lot of memory and can probably be optimized to be faster. #
Describe the solution you'd like to see.
Try to get rid of unnecessary memory allocations and speed up the algorithm. We might want to drop the
strings.Split()
allocations and just use a combinationstring.Index
and other lookups. On top of this, we might want to dry to do a binary search in the wordlist to speed up prefix matching.The text was updated successfully, but these errors were encountered: