Add GM check for advantage scenarios

Abort Advantage updates if not the GM when
- adding a condition
- creating a combatant
- deleting a combatant

CHANGELOG.md

@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.  The format
 
 ## Unreleased
 See [Issue Backlog](../../issues) and [Roadmap](../../milestones).
+- *Fixed* issue where players would see permission errors during advantage updates on other users' actors.
 
 ## [Version 0.9.4.2](https://github.com/Jagusti/fvtt-wfrp4e-gmtoolkit/releases/tag/v0.9.4.2)  (2022-07-29)
 - *Added* localization improvements for Condition Check and Secret Group Test macros. (Thanks @Txus5012!) [[#141](https://github.com/Jagusti/fvtt-wfrp4e-gmtoolkit/pull/141)] 

modules/advantage.mjs

@@ -408,6 +408,7 @@ Hooks.on("createActiveEffect", async function(conditionEffect) {
 
     // Exit if not using condition automation, or if Group Advantage is in play
     if ((!game.settings.get(GMToolkit.MODULE_ID, "automateConditionAdvantage")) || (game.settings.get("wfrp4e", "useGroupAdvantage"))) return 
+    if ((!game.user.isUniqueGM)) return 
 
     if (!conditionEffect.isCondition) return 
     let condId = conditionEffect.conditionId
@@ -434,15 +435,15 @@ Hooks.on("createActiveEffect", async function(conditionEffect) {
 Hooks.on("createCombatant", function(combatant) {    
     // ADDING TO COMBAT: clear token Advantange only if enabled, and Group Advantage is not being used. 
     // If Group Advantage is used, the system handles syncing individual advantage with the group
-    if (game.settings.get(GMToolkit.MODULE_ID, "clearAdvantageCombatJoin") && !(game.settings.get("wfrp4e", "useGroupAdvantage"))) {
+    if (game.user.isUniqueGM && game.settings.get(GMToolkit.MODULE_ID, "clearAdvantageCombatJoin") && !(game.settings.get("wfrp4e", "useGroupAdvantage"))) {
         let token = canvas.tokens.placeables.filter(a => a.data._id == combatant.data.tokenId)[0]
         Advantage.update(token, "clear", "createCombatant");
         Advantage.unsetFlags([combatant])
     } 
 });
 
 Hooks.on("deleteCombatant", function(combatant) {
-    if (game.settings.get(GMToolkit.MODULE_ID, "clearAdvantageCombatLeave")) {
+    if (game.user.isUniqueGM && game.settings.get(GMToolkit.MODULE_ID, "clearAdvantageCombatLeave")) {
         let token = canvas.tokens.placeables.filter(a => a.data._id == combatant.data.tokenId)[0]
         Advantage.update(token, "clear", "deleteCombatant");
         Advantage.unsetFlags([combatant], true)