Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Group Advantage] The Add Advantage macro does not increase Group Advantage past 10. #194

Closed
TheFirst05 opened this issue Oct 9, 2022 · 1 comment · Fixed by #195
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@TheFirst05
Copy link

TheFirst05 commented Oct 9, 2022

Sometimes with Group Advantage we manage to accrue more than 10 advantage. The Add Advantage macro does not increase the value past 10. We need to manually change the number in the box of the Combat tracker to increase it. Is there a way to do this?

Versions

  • All up to date as of this report.

Console Log

Nothing in the console log

Edit: I've just worked out that its tied to max advantage right? Because Advantage automation does not increase past 10. This might have been for something for WFRP4e system instead of gmtoolkit. Sorry.

@Jagusti Jagusti added the bug Something isn't working label Oct 10, 2022
@Jagusti
Copy link
Owner

Jagusti commented Oct 10, 2022

This might have been for something for WFRP4e system instead of gmtoolkit.

TBF, as you can increase the Advantage above 10 editing the pool directly, so I'm happy the system is doing what it needs to. I'll add a check to ignore the max check if Group Advantage is being used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants