Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot render settings submenus in FVTT v9 #70

Closed
Tracked by #69
Jagusti opened this issue Dec 31, 2021 · 0 comments · Fixed by #71 or #75
Closed
Tracked by #69

Cannot render settings submenus in FVTT v9 #70

Jagusti opened this issue Dec 31, 2021 · 0 comments · Fixed by #71 or #75
Assignees
@Jagusti
Labels
bug Something isn't working compatibility Required to ensure compatibility with changes in platform, system or other dependencies
Milestone
0.9.0 FVTT v9 Com...

Comments

@Jagusti
Copy link
Owner

Jagusti commented Dec 31, 2021 

foundry.js:316 Error: An error occurred while rendering GMToolkitAdvantageSettings 48: You must specify both namespace and key portions of the setting
    at ClientSettings.get (foundry.js:2113)
    at gm-toolkit-settings.mjs:285
    at Array.forEach (<anonymous>)
    at getDataSettings (gm-toolkit-settings.mjs:272)
    at GMToolkitAdvantageSettings.getData (gm-toolkit-advantage-settings.js:18)
    at GMToolkitAdvantageSettings._render (foundry.js:3031)
    at GMToolkitAdvantageSettings._render (foundry.js:3733)
    at GMToolkitAdvantageSettings.render (foundry.js:2990)
    at SettingsConfig._onClickSubmenu (foundry.js:55267)
    at HTMLButtonElement.dispatch (jquery.min.js:2)
@Jagusti Jagusti added bug Something isn't working compatibility Required to ensure compatibility with changes in platform, system or other dependencies labels Dec 31, 2021
@Jagusti Jagusti added this to the FVTT v9 Compatibility milestone Dec 31, 2021
@Jagusti Jagusti self-assigned this Dec 31, 2021
@Jagusti Jagusti mentioned this issue Dec 31, 2021
Closed
14 tasks
Jagusti added a commit that referenced this issue Dec 31, 2021
@Jagusti
Specify namespace for submenu settings to render
5348cd0 
Fixes #70
@Jagusti Jagusti mentioned this issue Dec 31, 2021
Merged
@Jagusti Jagusti linked a pull request Dec 31, 2021 that will close this issue
Specify namespace for submenu settings to render #71
Merged
@Jagusti Jagusti mentioned this issue Dec 31, 2021
Closed
@Jagusti Jagusti linked a pull request Jan 2, 2022 that will close this issue
Add FVTT v9 and WFRP v5 Compatibility #75
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jagusti Jagusti

Labels
bug Something isn't working compatibility Required to ensure compatibility with changes in platform, system or other dependencies
Projects
None yet
Milestone
0.9.0 FVTT v9 Compatibility
1 participant
@Jagusti