Add extra symlinks for clang-cl compatibility with /winsdkdir and /vctoolsdir #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the sdk/ tree follow Visual Studio's layout, allowing these paths to work as expected with clang-cl's /winsdkdir and /vctoolsdir options.
Because again, this is the layout that clang-cl expects.
Jake-Shadle
changed the title
messense
reviewed
May 16, 2022
| let mut versioned_linkname = roots.sdk.clone(); | ||
| versioned_linkname.push("lib"); | ||
| versioned_linkname.push(sdk_version); | ||
| symlink(".", &versioned_linkname)?; |
There was a problem hiding this comment.
Just tried this in xwin 0.2.2, looks like this will fail when more than one architectures are specified?
Error: failed to splat Win10SDK_10.0.20348_libs_aarch64.msi
Caused by:
0: unable to symlink from /home/runner/.cache/cargo-xwin/xwin/sdk/lib/10.0.20348 to .
1: File exists (os error 17)
https://github.com/messense/cargo-xwin/runs/6448797813?check_suite_focus=true
Works fine when only one architecture is specified.
There was a problem hiding this comment.
Whoopsie! Thank you for fixing that 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44.
I ended up also adding two more symlinks for case-sensitive filesystems,
sdk/Include -> sdk/includeandsdk/Lib -> sdk/lib, because that's apparently also the layout that clang-cl expects.